Conversation
|
ship it! |
|
Has this been tested? Can it be merged into master? |
|
This has been tested and it works, but I have a few changes to make before merging this. |
|
Should the API expose the three methods that are there now, or should there be just one |
|
The latter. It would be cool to have a |
7b94b99 to
89f247f
Compare
|
This needs to sanity-checked on a Pi, but is ready for review /cc @EasternEdgeRobotics/developers |
There was a problem hiding this comment.
If we want to observe multiple raspi we will need a name field
There was a problem hiding this comment.
Where the images don't have their hostnames set to anything meaningful, would it be better to attach a name externally instead? That is, in each entry point, when wiring up this information, we can map machines to the streams (somehow).
(Which might be doubly useful if we need to map machines to other information.)
There was a problem hiding this comment.
We could make our own composite class to wrap names with an object? Essentially a clone of the timestamped class you mentioned the other day.
There was a problem hiding this comment.
That would work, yeah. How does that sound?
|
Ship it |
Add Raspberry Pi sensor observables
Closes #53
This PR implements observables for CPU voltage, frequency, and temperature (via Pi4J's
SystemInfomethods). The usage is simple enough; a 1 minute poll interval: