Allow to upload/remove images in Image fields#3962
Merged
javiereguiluz merged 1 commit intoEasyCorp:masterfrom Nov 18, 2020
Merged
Allow to upload/remove images in Image fields#3962javiereguiluz merged 1 commit intoEasyCorp:masterfrom
javiereguiluz merged 1 commit intoEasyCorp:masterfrom
Conversation
Contributor
|
OMG, seems this is my fail... i don't understand why changes about batch actions and other here |
Contributor
|
i fixed my branch anyway |
Collaborator
Author
|
@versh23 thanks for taking care of that. However, I prefer to merge this PR because I need this feature in one of my apps ASAP. Hopefully I'll soon look into your other pending pull requests 🙏 |
javiereguiluz
force-pushed
the
image_upload
branch
from
81f0a66 to
60bd197
Compare
3 tasks
Contributor
|
sadly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reintroduces the great feature that Yonel (@yceruto) implemented in EasyAdmin 2.x.
Changes are based completely on the work done by @versh23 in #3511. I can't merge that PR because it includes many unrelated changes in the same PR, so I prefer to create separate PRs.
Please note that in the future (hopefully soon) we'll add a File field and we could refactor some of this code to reuse it for images and files. Also, some of the FileUploadType are not exposed yet as Image field methods ... but we'll do that too in the future.