Add support for loading Webpack Encore entries#4223
Merged
Conversation
OskarStark
reviewed
Feb 20, 2021
| {% endfor %} | ||
|
|
||
| {% for webpack_encore_entry in ea.assets.webpackEncoreEntries ?? [] %} | ||
| {{ ea_call_function_if_exists('encore_entry_script_tags', webpack_encore_entry) }} |
Collaborator
There was a problem hiding this comment.
Isn't there a twig possibility to check if a method is defined, instead of wrapping it again in a php method? Maybe this can be provided as native twig function?
Collaborator
Author
There was a problem hiding this comment.
None that I'm aware of ... that's why we defined a similar ea_apply_filter_if_exists filter in the past:
Collaborator
There was a problem hiding this comment.
@fabpot any thoughts on having this on twig instead project level?
javiereguiluz
force-pushed
the
fix_4213
branch
from
9fb8980 to
1aa5bc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4213.
The method name is a bit long (
addWebpackEncoreEntry()) but I prefer it because it's completely explicit about its intent.