Simplify dropdown menu html and move styles from span elements to classes#5648
Merged
javiereguiluz merged 1 commit intoEasyCorp:4.xfrom Mar 11, 2023
Merged
Simplify dropdown menu html and move styles from span elements to classes#5648javiereguiluz merged 1 commit intoEasyCorp:4.xfrom
javiereguiluz merged 1 commit intoEasyCorp:4.xfrom
Conversation
Lustmored
approved these changes
Feb 22, 2023
Contributor
Lustmored
left a comment
Lustmored
left a comment
There was a problem hiding this comment.
I was helping along with this PR and can confirm that it makes this menu look better
|
I also noticed this problem and this fix would be great! |
javiereguiluz
force-pushed
the
style_updates
branch
from
41eabbf to
c095385
Compare
Collaborator
|
Thanks @TmszLBmrv and sorry it took us so long to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that language links in dropdown-menu have no padding after latest updates, because those links have no span elements that take care of that.
The lazy solution would be to just put
{{ localeDto.name }}in span, but in my opinion, the span elements are just not necessary. It would be better to move padding to dropdown-items. That way, html is simpler and if in some cases you would still like to do some nesting there, you can usespanwithout breaking anything, because it has no styles attached.I also got rid of few icon styles in those items, because fa-fw takes care of the styles that were used there, plus fixed height prevented icons from centering vertically.
Before:
After:
