Conversation
|
The test issues will be fixed when twigphp/Twig#4511 is released. |
|
@javiereguiluz the dev version of Twig 3.x should be working now thanks to twigphp/Twig#4575 |
javiereguiluz
force-pushed
the
twig_guard
branch
from
0e8051b to
80c601d
Compare
|
@stof I just updated this and I can confirm that your fix worked perfectly! 🙇 Thanks so much! |
javiereguiluz
force-pushed
the
twig_guard
branch
from
5429b55 to
99f4f73
Compare
| "symfony/security-bundle": "^5.4|^6.0|^7.0", | ||
| "symfony/string": "^5.4|^6.0|^7.0", | ||
| "symfony/translation": "^5.4|^6.0|^7.0", | ||
| "symfony/twig-bridge": "^5.4,>=5.4.48|^6.0,>=6.4.16|^7.0,>=7.1.9", |
There was a problem hiding this comment.
This can be simplified as ^5.4.48|^6.4.16|^7.1.9
There was a problem hiding this comment.
I'll make this change, thanks 🙏
| <link rel="stylesheet" href="{{ (css_asset.preload ? ea_call_function_if_exists('preload', href, { as: 'style', nopush: css_asset.nopush }))|default(href) }}" | ||
| {%- for attr, value in css_asset.htmlAttributes %} {{ attr }}="{{ value|e('html') }}"{% endfor %}> | ||
| {% if css_asset.preload %} | ||
| {% guard function preload %} |
There was a problem hiding this comment.
If the preload function is not defined, shouldn't this fallback to the non-preload styles instead of not loading the CSS at all ?
There was a problem hiding this comment.
In most Symfony projects, yes. In this project, we always check (and throw an exception) if you don't have the needed code for some feature that you are using (see e.g.
EasyAdminBundle/src/Config/Asset.php
Lines 69 to 71 in da8f4e2
Then, if we always check first, why do we need this guard tag? Because our checks are at runtime and Twig fails at compile-time if some function doesn't exist. That's why we need the compile-time protection that guard brings. Thanks!
| <script src="{{ (js_asset.preload ? ea_call_function_if_exists('preload', src, { as: 'script', nopush: js_asset.nopush }))|default(src) }}" {{ js_asset.async ? 'async' }} {{ js_asset.defer ? 'defer' }} | ||
| {%- for attr, value in js_asset.htmlAttributes %} {{ attr }}="{{ value|e('html') }}"{% endfor %}></script> | ||
| {% if js_asset.preload %} | ||
| {% guard function preload %} |
2 participants
Twig 3.5 added the nice
guardtag (https://twig.symfony.com/doc/3.x/tags/guard.html) to solve problems like the ones we have. So, let's use it.