Fix #6529 / #6732 : Check if entity is Accessible before processActions in EntityFactory#6772
Open
octoseth wants to merge 16 commits intoEasyCorp:4.xfrom
Open
Fix #6529 / #6732 : Check if entity is Accessible before processActions in EntityFactory#6772octoseth wants to merge 16 commits intoEasyCorp:4.xfrom
octoseth wants to merge 16 commits intoEasyCorp:4.xfrom
Conversation
|
Thanks, your fix works! How is this not merged yet? |
|
Hi @javiereguiluz can you please look at this PR? This bugs affected many projects. |
|
Any news about this merge? |
Contributor
|
@kikwik did you find a solution? |
@gremo No, currently I'm not using that feature. like this: final class ActionFactory
{
public function processEntityActions(EntityDto $entityDto, ActionConfigDto $actionsDto): void
{
if (!$entityDto->isAccessible()) {
return;
}
// here the rest of the easy admin code....
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Today I encountered issues #6529 and #6732 in a project, so I propose this fix.
This pull request includes changes to the
EntityFactoryclass in thesrc/Factory/EntityFactory.phpfile. The main update is the addition of an accessibility check for entities before processing actions, which ensures that only accessible entities are processed.Entity accessibility check:
src/Factory/EntityFactory.php: Added a check to skip processing for entities that are not accessible in theprocessActionsForAllmethod.