Allow 'notice' and 'error' flash message keys#7015
Merged
javiereguiluz merged 2 commits intoEasyCorp:4.xfrom Jul 5, 2025
Merged
Allow 'notice' and 'error' flash message keys#7015javiereguiluz merged 2 commits intoEasyCorp:4.xfrom
javiereguiluz merged 2 commits intoEasyCorp:4.xfrom
Conversation
These are commonly used, according to https://symfony.com/doc/current/session.html#flash-messages .
VincentLanglet
suggested changes
Jun 26, 2025
Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com>
msphn
suggested changes
Jul 3, 2025
| return 'alert-'.match ($this) { | ||
| self::Primary, self::Secondary, self::Success, self::Danger, self::Warning, self::Info, self::Light, self::Dark => $this->value, | ||
| self::Notice => 'info', | ||
| self::Error => 'danger', |
There was a problem hiding this comment.
why not using here self::Danger and self::Info?
Collaborator
|
Thanks Jon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part 1 of issue 7014 (allowing the "commonly used" flash keys).