[Docs] Use named argument icon for Action::new()
#7404
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm tweaking my admin interface a little, and I needed to add a new custom action with an icon. Without `icon:`, 'fas fa-file-invoice' is used as the button text. Thanks!
Collaborator
|
Good catch! Thanks Hugo. However, there was another error (which indirectly caused the other error): the action was missing its name! This is an internal ID for the action that is used e.g. when updating actions, in the CSS classes for the generated action, etc. It must be the first argument. So, I fixed that too while merging. Thanks! |
Contributor
Author
|
Yeah I saw other actions has id/label/icon arguments, but I wasn't sure here. Thanks Javier! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm tweaking my admin interface a little, and I needed to add a new custom action with an icon.
Without
icon:,fas fa-file-invoiceis used as the button text.Thanks!