Introduce an AdminControllerRegistry#7412
Merged
javiereguiluz merged 1 commit intoEasyCorp:4.xfrom Feb 5, 2026
Merged
Conversation
javiereguiluz
force-pushed
the
improve_registries
branch
from
194d917 to
9fbc869
Compare
javiereguiluz
force-pushed
the
improve_registries
branch
from
9fbc869 to
7c6b291
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last piece we need to be able to release the 5.x version.
CrudControllerRegistryandDashboardControllerRegistryare mostly internal classes that holds a registry of all the controllers that define a CRUD controller or a Dashboard controller. Some of their features are outdated and make no sense when using pretty URLs.Since 5.x requires pretty URLs and deep Symfony controller integrations via
#[AdminRoute]we can simplify many things. So, let's merge both registries into a new singleAdminControllerRegistrythat stores everything and provides useful methods that still must be used.