Do not convert translatable enum choices into an associative array#7629
Open
Seb33300 wants to merge 1 commit into
Open
Do not convert translatable enum choices into an associative array#7629Seb33300 wants to merge 1 commit into
Seb33300 wants to merge 1 commit into
Conversation
Seb33300
changed the title
|
Works for me thanks @Seb33300! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7242
EasyAdmin was transforming all enum choices into an associative array.
But we should not transform translatable enums and let the
EnumTypeto handle enums with its own logic.Note: we cannot completely remove the associative array because it is used later in the code to handle translations.
So we just remove keys when passing it to the
choicesform option.Different approach from #7243 as suggested by #7243 (comment)