Prepare for docker builds in CI #842
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdupress
force-pushed
the
docker-builds-in-ci
branch
from
fe424ef to
a6bb879
Compare
fdupress
force-pushed
the
docker-builds-in-ci
branch
from
a6bb879 to
14847f6
Compare
fdupress
force-pushed
the
docker-builds-in-ci
branch
from
14847f6 to
7d980bd
Compare
Member
Author
|
Right—putting this one on pause. It is silly to run this as a matrix when the base is build in all 3 jobs, but can't be shared. I need to rethink this—including whether we want to publish the base and build images. On the plus side, the build is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays the groundwork for being able to generate dockerfiles in CI. I added a workflow_dispatch trigger so docker containers corresponding to specific branches (other than
main,latest, and release tags) can also be produced. Hopefully, I can use it to test the change.At the moment, the script tries to push the container to the GHCR—this hopefully should fail without first putting effort into setting credentials and a secure environment. (But who knows?)
This is separated from the Jasmin in CI work to allow us to take baby steps on publishing containers, especially since this changes the meaning of the
latesttag in container world. (This will be following latest release, our currentlatestis "whatever was in the repo last time someone bothered to update the container.")We could run only the
buildjob, but given that the image is tagged with the relevant branch, it might be useful to actually produce thetestbox (and later, theformosabox) and make sure that inter-workflow dependencies are clear.