Internal: correctly preserve match statements when constructing a zipper#899
Merged
Internal: correctly preserve match statements when constructing a zipper#899
Conversation
strub
requested changes
Feb 13, 2026
Member
strub
left a comment
strub
left a comment
There was a problem hiding this comment.
It is ok for prebr to be reversed (this is how zipper works, this allows to have more efficient concatenation & "sibling" navigation). The error is more in the reconstruction routine (later in this file): List.rev_cat should be used in place of @.
Cameron-Low
force-pushed
the
fix-zipper-match
branch
from
ba5c77a to
a377f9a
Compare
strub
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.