Fix rolling CI#66
Open
Butakus wants to merge 2 commits into
Open
Conversation
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
This PR fixes the CI in rolling by moving to a different container using Ubuntu 26 via https://github.com/ros-tooling/setup-ros-docker containers.
I did also fixed an error coming from the
ament_index_cpp::get_package_share_directory(...)function which is now deprecated. The new way isament_index_cpp::get_package_share_path(...)which returns anstd::filesystem::pathinstead of astd::string.After going back to a working CI, I found a runtime error in some test files that use
std::normal_distributionwith zero std (which seems to be undefined behavior). I will open an issue now and maybe provide a fix later.