Skip to content

[fix] Add missing address parameters to Shipment create parameter set #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[fix] Add missing address parameters to Shipment create parameter set #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions EasyPost/Parameters/Shipment/Create.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,26 @@ public class Create : BaseParameters<Models.API.Shipment>, IShipmentParameter
[NestedRequestParameter(typeof(ScanForm.Create), Necessity.Optional, "from_address")]
public IAddressParameter? FromAddress { get; set; }

/// <summary>
/// The return <see cref="Models.API.Address"/> (or a <see cref="Address.Create"/> parameter set) for the new <see cref="Models.API.Shipment"/>.
/// </summary>
[TopLevelRequestParameter(Necessity.Optional, "shipment", "return_address")]
[NestedRequestParameter(typeof(Pickup.Create), Necessity.Optional, "return_address")]
[NestedRequestParameter(typeof(Batch.Create), Necessity.Optional, "return_address")]
[NestedRequestParameter(typeof(Order.Create), Necessity.Optional, "return_address")]
[NestedRequestParameter(typeof(ScanForm.Create), Necessity.Optional, "return_address")]
public IAddressParameter? ReturnAddress { get; set; }

/// <summary>
/// The buyer <see cref="Models.API.Address"/> (or a <see cref="Address.Create"/> parameter set) for the new <see cref="Models.API.Shipment"/>.
/// </summary>
[TopLevelRequestParameter(Necessity.Optional, "shipment", "buyer_address")]
[NestedRequestParameter(typeof(Pickup.Create), Necessity.Optional, "buyer_address")]
[NestedRequestParameter(typeof(Batch.Create), Necessity.Optional, "buyer_address")]
[NestedRequestParameter(typeof(Order.Create), Necessity.Optional, "buyer_address")]
[NestedRequestParameter(typeof(ScanForm.Create), Necessity.Optional, "buyer_address")]
public IAddressParameter? BuyerAddress { get; set; }

/// <summary>
/// The physical <see cref="Models.API.Parcel"/> (or <see cref="Parcel.Create"/> parameter set) being transported in the new <see cref="Models.API.Shipment"/>.
/// </summary>
Expand Down