Skip to content

Maniacs Feature - Add .relative & .centered support on PixelPanScreen#3302

Merged
Ghabry merged 1 commit intoEasyRPG:masterfrom
ToolMan2k:PixelScrolling
Nov 24, 2024
Merged

Maniacs Feature - Add .relative & .centered support on PixelPanScreen#3302
Ghabry merged 1 commit intoEasyRPG:masterfrom
ToolMan2k:PixelScrolling

Conversation

@ToolMan2k
Copy link
Copy Markdown
Contributor

By Ghabry's request, here's the missing function .relative & .centered scrolling.

When using .relative & .centered tags for PixelScrolling, do the following:

  • Get half the width/height of the screen
  • Move screen by ( h/v - screen_width/height ) divided by two.

Tested against Maniac Patch 240822, it works as expected.
Tested using different resolutions on Maniac and EasyRPG, works as expected.

@Ghabry
Copy link
Copy Markdown
Member

Ghabry commented Nov 23, 2024

Great thanks for figuring out the algorithm

When using .relative & .centered tags for PixelScrolling, do the following:
- Get half the width/height of the screen
- Move screen by ( h/v - screen_width/height ) divided by two.

When compared to Maniacs Patch 240822, it works as expected.
Tested using different resolutions, works like it should.
@Ghabry
Copy link
Copy Markdown
Member

Ghabry commented Nov 24, 2024

Jenkins: Test this please

Rebased the commit and deleted the merge commit. Looks good to me now 👍

@Ghabry Ghabry merged commit d9dd9be into EasyRPG:master Nov 24, 2024
@Ghabry
Copy link
Copy Markdown
Member

Ghabry commented Dec 3, 2024

@ToolMan2k sorry just tagging you here because there are no private messages on github:

We noticed you started working on GetGameInfo ToolMan2k@9dffc8f

Some of the parameter mapping was already figured out in Jetrotals CSA: https://jetrotal.github.io/CSA/#TPC%20|%20Get%20Game%20Info

Maybe saves you some time of trial and error :)

If you have any questions feel free to join our chat https://easyrpg.org/contact/ or ask in the forum https://community.easyrpg.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants