Audio: Add support for panning#3432
Merged
Ghabry merged 6 commits intoEasyRPG:masterfrom Jun 23, 2025
Merged
Conversation
Contributor
|
Why are the checks stuck? |
Member
|
jenkins: ok to test.
New contributors need to be approved by the team. |
Contributor
I see, thanks |
Ghabry
reviewed
Jun 8, 2025
Tested with opus and fluidsynth Closes EasyRPG#2585
Desdaemon
force-pushed
the
upstream-master
branch
2 times, most recently
from
911693d to
602af2e
Compare
Desdaemon
force-pushed
the
upstream-master
branch
from
602af2e to
076479c
Compare
Closed
Desdaemon
force-pushed
the
upstream-master
branch
from
2b945b9 to
2b8564c
Compare
Member
|
did a Frida trace with another MIDI file: Matches perfectly. Great job! (This means any further difference in terms of MIDI volume is now related to the Soundfont and the Midisynth/library used, so out of scope for this PR) |
ghost
approved these changes
Jun 14, 2025
Contributor
|
Hold on, I tested Wav, and there's something very wrong, but it's complicated. |
Ghabry
reviewed
Jun 15, 2025
Member
Ghabry
left a comment
Ghabry
left a comment
There was a problem hiding this comment.
Only some nitpicks left.
Thanks again for the contribution and lt-knb for the testing.
Ghabry
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with opus and fluidsynth, more rigorous testing with other backends may be needed.
Closes #2585