Skip to content

Conversation

@fdelapena
Copy link
Contributor

Fixes EasyRPG/Player#649

ICU from toolchains will need to be rebuilt to make this update work properly.

After updating toolchains also closes EasyRPG/Player#746

@Ghabry
Copy link
Member

Ghabry commented Nov 18, 2015

Is that encoding not supported in the static toolchains? :(

@fdelapena
Copy link
Contributor Author

Not tested, the icudata demo should explain codepage dependencies better. I can check it tonight.

@fdelapena
Copy link
Contributor Author

Confirmed, it is an independent encoding, dat file needs to be updated.

@carstene1ns
Copy link
Member

datfile

@Ghabry
Copy link
Member

Ghabry commented Nov 19, 2015

You can now embed word documents to github comments iirc. So you can embed "dat file" in the word document and upload that one :D

@fdelapena
Copy link
Contributor Author

Here is the .dat download link, for ICU56

@Ghabry
Copy link
Member

Ghabry commented Nov 19, 2015

datfile.docx

@fdelapena
Copy link
Contributor Author

After further testing, yet another issue. This time with middle dot conversion into UTF-8:

When trying to read some file with middle dot, we have 2 possibilities, depending on encoding:
U+00B7 · middle dot (windows-949-2000, uses backslash)
U+30FB ・ katakana middle dot (ibm-1363_P110-1997, uses Won)

Tests:
--encoding windows-949-2000 --start-map-id 11 --new-game
--encoding ibm-1363_P110-1997 --start-map-id 11 --new-game

Not sure which filename is the right on real Korean Win32 zip decoding. At least after using convmv to convert unzipped files on non-Win32, it needs windows-949-2000 to find this file properly.

@fdelapena fdelapena added this to the 0.4 milestone Nov 20, 2015
@carstene1ns
Copy link
Member

time to get a windows 98 vm ready 😀

@fdelapena fdelapena changed the title Change Korean encoding to ibm-1363 Change Korean encoding to windows-949-2000 Dec 13, 2015
@fdelapena
Copy link
Contributor Author

Can't test this until EasyRPG/Player#673 is fixed.

@fdelapena
Copy link
Contributor Author

After unpacking a zip using Korean locale on Windows, it seems to use U+00B7, so windows-949-2000 (with \ ) is the current candidate. Do not merge until checking deeper on Win32 with a full icudata.

@fdelapena fdelapena removed this from the 0.4 milestone Dec 17, 2015
@Ghabry
Copy link
Member

Ghabry commented Feb 11, 2016

Is this still pending fix?

@fdelapena
Copy link
Contributor Author

Is this still pending fix?

Fixed, tested and ready.

@fdelapena
Copy link
Contributor Author

It looks like Japanese encoding needed an update too... it does not detect filenames with ~ properly and the new encoding kills backslash to yen conversion 😭.

@fdelapena
Copy link
Contributor Author

Ready for your ICU rebuilds. ^^

@fdelapena fdelapena changed the title Change Korean encoding to windows-949-2000 Change Korean and Japanese encodings to fix file finding errors Feb 16, 2016
Ghabry added a commit that referenced this pull request Mar 2, 2016
Change Korean and Japanese encodings to fix file finding errors
@Ghabry Ghabry merged commit 9bce947 into EasyRPG:master Mar 2, 2016
@fdelapena fdelapena deleted the player-649 branch March 2, 2016 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

ICU data file needs Thai (874) Nobita's Biohazard Korean translation tries to load file name with wrong encoding

3 participants