-
Notifications
You must be signed in to change notification settings - Fork 62
Change Korean and Japanese encodings to fix file finding errors #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is that encoding not supported in the static toolchains? :( |
|
Not tested, the icudata demo should explain codepage dependencies better. I can check it tonight. |
|
Confirmed, it is an independent encoding, dat file needs to be updated. |
|
You can now embed word documents to github comments iirc. So you can embed "dat file" in the word document and upload that one :D |
|
Here is the .dat download link, for ICU56 |
|
After further testing, yet another issue. This time with middle dot conversion into UTF-8: When trying to read some file with middle dot, we have 2 possibilities, depending on encoding: Tests: Not sure which filename is the right on real Korean Win32 zip decoding. At least after using convmv to convert unzipped files on non-Win32, it needs windows-949-2000 to find this file properly. |
|
time to get a windows 98 vm ready 😀 |
|
Can't test this until |
|
After unpacking a zip using Korean locale on Windows, it seems to use U+00B7, so windows-949-2000 (with \ ) is the current candidate. Do not merge until checking deeper on Win32 with a full icudata. |
|
Is this still pending fix? |
Fixed, tested and ready. |
|
It looks like Japanese encoding needed an update too... it does not detect filenames with ~ properly and the new encoding kills backslash to yen conversion 😭. |
|
Ready for your ICU rebuilds. ^^ |
Change Korean and Japanese encodings to fix file finding errors

Fixes EasyRPG/Player#649
ICU from toolchains will need to be rebuilt to make this update work properly.
After updating toolchains also closes EasyRPG/Player#746