Angular 22 - #16
Merged
Merged
Conversation
Amongst other things, this update eslint and their rules, helping us prepare for incoming Angular 22.
Except: - @types/node, we run on node 22 - typescript, angular is not ready
There was a problem hiding this comment.
Pull request overview
Updates the workspace and published library to Angular v22, modernizing runtime and tooling (zoneless change detection, updated dependencies) and migrating tests away from Karma/Jasmine.
Changes:
- Bump Angular/CLI/build tooling to v22 and TypeScript to v6.
- Switch Angular library tests from Karma/Jasmine to the
@angular/build:unit-testbuilder with Vitest, and update CI accordingly. - Remove Zone.js polyfills and environment file replacements; bootstrap the demo app with zoneless change detection.
Reviewed changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Adjust TypeScript path mappings and Angular compiler options for the v22 toolchain. |
| src/tsconfig.spec.json | Simplify spec TS config as part of the Vitest migration. |
| src/main.ts | Bootstrap demo app using zoneless change detection provider. |
| src/environments/environment.ts | Remove legacy environment setup. |
| src/environments/environment.prod.ts | Remove legacy production environment setup. |
| src/app/images.ts | Add a large static image dataset used by the demo. |
| projects/angular-natural-gallery/tsconfig.spec.json | Align library spec TS config with the new unit test runner. |
| projects/angular-natural-gallery/tsconfig.lib.json | Update library Angular compiler options for v22. |
| projects/angular-natural-gallery/src/lib/natural-gallery/natural-gallery.component.spec.ts | Migrate the library unit test to Vitest imports. |
| projects/angular-natural-gallery/src/lib/natural-gallery/natural-gallery.component.html | Remove an unused template comment. |
| projects/angular-natural-gallery/package.json | Update Angular peer dependency range to v22. |
| projects/angular-natural-gallery/karma.conf.js | Remove Karma configuration (no longer used). |
| package.json | Replace Karma/Jasmine deps with Vitest/jsdom and bump Angular/TypeScript tooling versions. |
| angular.json | Switch library test target to @angular/build:unit-test with runner: vitest; remove zone/environment-related config. |
| .github/workflows/main.yml | Update CI test command for the new test runner configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+15
to
+17
| export const images: Image[] = [ | ||
| { | ||
| id: 'cok-OxpkrKQ', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.