Refactor Docker compose configuration to run multiple portals at same time - #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to improve running multiple portals at once.
Docker Compose and Volume Configuration Updates:
COMPOSEvariable inTaskfile.ymlso thatdocker/compose.ymlis loaded before the core base file, ensuring the correct override order.appservice indocker/compose.ymlto use the correct build context (../../) and Dockerfile path (madrona-apps/wcoa/docker/Dockerfile) for clarity and maintainability.docker/compose.ymlfrom short-form to long-formtype: bindsyntax withcreate_host_path: false, which is more explicit and compatible with newer Docker Compose versions.Dependency Management:
docker/requirements.txtfile as a placeholder for project-specific Python dependencies required by the Docker image.