Skip to content

Remove NYM mixFetch per-host request queue#717

Merged
samholmes merged 1 commit intoEdgeApp:masterfrom
bobbythelobster:edgar/remove-nym-mixfetch-queue
Mar 17, 2026
Merged

Remove NYM mixFetch per-host request queue#717
samholmes merged 1 commit intoEdgeApp:masterfrom
bobbythelobster:edgar/remove-nym-mixfetch-queue

Conversation

@bobbythelobster
Copy link
Copy Markdown

@bobbythelobster bobbythelobster commented Mar 17, 2026

The per-host request queue was a workaround for a mixFetch limitation that has been resolved in @nymproject/mix-fetch@1.4.2. Callers now use initMixFetch directly to obtain the fetch function.

Changes

  • src/util/nym.ts: Remove queueMixFetch, hostRequestChains Map, and getHostKey helper. initMixFetch and mixFetchOptions remain unchanged.
  • src/io/browser/browser-io.ts: Replace queueMixFetch call with direct initMixFetch + nymFetch call.
  • src/io/react-native/react-native-worker.ts: Same as browser-io.

Impact

  • 3 files changed, 8 insertions, 66 deletions (net -58 lines)
  • All 162 tests pass
  • TypeScript compiles cleanly

Relates to Asana task 1213688999708248


@bobbythelobster bobbythelobster force-pushed the edgar/remove-nym-mixfetch-queue branch 2 times, most recently from ae1d054 to da07776 Compare March 17, 2026 21:42
Comment thread CHANGELOG.md Outdated

## Unreleased

- changed: Upgrade `@nymproject/mix-fetch` to v1.4.3.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this changelog entry because it's a moot point.

@bobbythelobster bobbythelobster force-pushed the edgar/remove-nym-mixfetch-queue branch from da07776 to 0d3eea7 Compare March 17, 2026 21:47
@bobbythelobster
Copy link
Copy Markdown
Author

✅ Review feedback addressed:

  • Removed CHANGELOG entry (commit 0d3eea7)

The CHANGELOG remains in 'Unreleased' state with no entries since the mixFetch upgrade is part of the ongoing NYM/privacy-fetch feature work, not a user-facing release change.

The per-host request queue was a workaround for a mixFetch limitation
that has been resolved in @nymproject/mix-fetch@1.4.2. Callers now use
initMixFetch directly to obtain the fetch function.
@samholmes samholmes force-pushed the edgar/remove-nym-mixfetch-queue branch from 0d3eea7 to 5916d9d Compare March 17, 2026 22:00
@samholmes samholmes enabled auto-merge March 17, 2026 22:17
@samholmes samholmes merged commit 7ebe086 into EdgeApp:master Mar 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants