Zorro Splash Screen brightness/contrast

[mixMugz]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

I have a custom Splash Screen in my Zorro TX. When I turn TX on, I see my splash, but it's very bright, and seems like the contrast is set to a minimum. If I set the contrast in TX to the maximum, my splash screen keeps the same (low bright) behavior.

How I can control my contrast values for boot splash? Why it not used TX values?

Look second screenshot.

Expected Behavior

The splash screen uses the main contrast value of TX.

Steps To Reproduce

1. Set a custom splash screen with lots of blacks
2. Set contrast in TX to maximum value
3. Turn off TX
4. Turn back TX to ON
5. Look the splash screen

Version

2.8.2

Transmitter

Radiomaster Zorro

Operating System (OS)

Windows

OS Version

Window 10 22H2

Anything else?

No response

[pfeerick]

Brightness and contrast values will be the firmware default, as at the time the splash screen is shown, the SD card hasn't even been mounted yet.

[mixMugz]

Contrast value will be the firmware default, as at the time the splash screen is shown, the SD card hasn't even been mounted yet.

How do I change the default value of firmware (if I wish to build custom firmware)? For now, it seems like the default value is set to a minimum.

[mixMugz]

I think it will be a good idea if the default value will be middle between min and max.

[pfeerick]

It basically is, but it tweaked slightly for different radio screens. For the zorro, it's probably set to 15 (where the range is 10 to 30).

If you're up for building a custom firmware, try adding || defined(RADIO_ZORRO) to line 848 and see if that is enough... maybe it just needs to be lifted just that little bit more.

edgetx/radio/src/targets/taranis/board.h

Lines 834 to 859 in 745c465

	#if defined(PCBX9D) || defined(PCBX9DP) || defined(PCBX9E)
	#define LCD_W 212
	#define LCD_H 64
	#define LCD_DEPTH 4
	#define LCD_CONTRAST_MIN 0
	#define LCD_CONTRAST_MAX 45
	#define LCD_CONTRAST_DEFAULT 25
	#else
	#define LCD_W 128
	#define LCD_H 64
	#define LCD_DEPTH 1
	#define IS_LCD_RESET_NEEDED() true
	#define LCD_CONTRAST_MIN 10
	#define LCD_CONTRAST_MAX 30
	#if defined(RADIO_TX12) || defined(RADIO_TX12MK2) || defined(RADIO_BOXER)
	#define LCD_CONTRAST_DEFAULT 20
	#elif defined(RADIO_TPRO) || defined(RADIO_FAMILY_JUMPER_T12) || defined(RADIO_TPRO) || defined(RADIO_COMMANDO8)
	#define LCD_CONTRAST_DEFAULT 25
	#else
	#define LCD_CONTRAST_DEFAULT 15
	#endif
	#if defined(RADIO_LR3PRO)
	// add offset 2px because driver (SH1106) of the 1.3 OLED is for a 132 display
	#define LCD_W_OFFSET 0x02
	#endif
	#endif

[mixMugz]

It basically is, but it tweaked slightly for different radio screens. For the zorro, it's probably set to 15 (where the range is 10 to 30).

If you're up for building a custom firmware, try adding || defined(RADIO_ZORRO) to line 848 and see if that is enough... maybe it just needs to be lifted just that little bit more.

So, this workaround worked great! Now the Splash screen looks like all other screens, but now I have a boot problem. It's too dark =( There is any place in the code where I can set contact for the initial boot (dots)??

[pfeerick]

There is any place in the code where I can set contact for the initial boot (dots)??

Unfortunately, not anything that has been specifically designed for that... you'd probably have to fudge with the contrast in the startup animation function to make that look nicer. As good as the B&W screens for normal usage, they also seem somewhat ... cheap and nasty for want of a better description. While there seems to be something a bit weird about how we use them as the "contrast" changes depending on how much content there is on the screen, to be honest, I've not looked at the B&W lcd driving code so it may just be a function of how these screens work.