Targets that uses spi flash should not enable disk cache

[richardclli]

Disk cache should not enable together with spi flash storage that uses frftl, this will cause double caching in sdram and wasting sdram space and slowdown file access.

Summary by CodeRabbit

• Chores
  • Modified default disk cache configuration setting.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f8131ac1-8fac-461a-9bed-e543ec1bbd0f

📥 Commits

Reviewing files that changed from the base of the PR and between f13f049 and 30d63cc.

📒 Files selected for processing (1)

• radio/src/targets/pl18/CMakeLists.txt

---

📝 Walkthrough

Walkthrough

The default value of the DISK_CACHE CMake build option in radio/src/targets/pl18/CMakeLists.txt is changed from ON to OFF. No other logic, options, or targets are modified.

Changes

DISK_CACHE Default Change for pl18

Layer / File(s)	Summary
DISK_CACHE default set to OFF radio/src/targets/pl18/CMakeLists.txt	The option(DISK_CACHE ...) declaration changes its default from ON to OFF. Existing conditional logic and all other options are unaffected.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description explains the technical rationale but lacks the structured format required by the repository template with sections like 'Fixes #' and 'Summary of changes:'.	Reformat the description to follow the repository template: add 'Fixes #' section referencing related issue(s) and use 'Summary of changes:' as the section header.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: disabling disk cache for targets using SPI flash storage to prevent performance issues.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch richardclli/fix-pl18-dup-diskcache

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[richardclli]

@pfeerick This is ready to merge, I have tested it.