fix(hwgen): prevent prefix collisions when resolving source names - #7533
Merged
Conversation
📝 WalkthroughWalkthroughThree name-lookup functions ( ChangesExact-length lookup checks
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The _lookup_input_idx, switchLookupIdx, and adcGetInputIdx functions used strncmp for prefix-only matching, causing 'SL' (switch) to match 'SL1' (slider) before switch lookup. Fix by requiring exact length match via strlen check to prevent prefix collisions between analog input names and switch names.
norulers
force-pushed
the
fix/sl-switch-prefix-collision
branch
from
July 7, 2026 09:01
4f1cdb3 to
e4767ae
Compare
raphaelcoeffic
approved these changes
Jul 7, 2026
pfeerick
pushed a commit
that referenced
this pull request
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _lookup_input_idx, switchLookupIdx, and adcGetInputIdx functions used strncmp for prefix-only matching, causing SL (switch) to match SL1 (slider) before switch lookup. Fix by requiring exact length match via strlen check to prevent prefix collisions between analog input names and switch names.
Closes: mixer source changing from SL to S3 after power cycle on T22