fix(t22): use PB15 and PJ12 for red LED due to USART1_RX DFU overlap - #7542
Merged
Conversation
📝 WalkthroughWalkthroughThis PR adds a second red LED GPIO (LED_RED2_GPIO) for the T22 target, defined as GPIOJ pin 12, and wires it into the shared LED driver's initialization, off, and red-on functions alongside the existing red LED. ChangesSecond Red LED GPIO Support
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
Ouch! Well, at least you can still do UF2 :-O |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7534 (or at least support the required hardware change, technical details in the issue itself)
Summary of changes:
To fix an issue of buddy been unable to flash T22, there needs to be an hardware change. Red led pin will be moved from the troublemaking PB15 in current T22 boards to PJ12 in future boards.
This software change supports the red led operation for both old and new boards (old still remains non buddy flashable)