fix(color): rotary encoder sometimes inoperative after LUA script exit - #7684
Merged
Conversation
3djc
changed the title
|
thank you for the fast resolution on this one! |
Collaborator
|
Looks good. |
pfeerick
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7509 backport did include 2 undue line that:
StandaloneLuaWindow's constructor runs before attach() → pushLayer(true). So at constructor time, lv_group_get_default() is still the parent layer's group (the SYS/pagegroup menu). The backported lines therefore do:
attach() then pushes a new layer and re-adds lvobj to the new group (lv_group_add_obj removes it from the old one), but editing = 1 is left behind on the parent group forever. On long-RTN, Layer::pop deletes the Lua group and restores the parent group as default — still stuck in edit mode, so the encoder sends LV_KEY_LEFT/RIGHT to the focused object instead of moving focus. Non-editable focus → wheel does nothing.
Fixes #7681
Not needed for main