This repository was archived by the owner on May 13, 2026. It is now read-only.
Background precomputation for deep view chains - #412
Merged
Conversation
Views deeper than level 1 (depending on other views) now precompute in background tasks instead of lazily on query. New ViewCacheState:: Computing state indicates precomputation is in progress — queries return a clear "not ready" error until it finishes. On source mutation: - Single-pass cascade collection (replaces per-step lock re-acquisition) - Deep views marked Computing, background task computes bottom-up - If precomputation fails, resets to Empty for lazy fallback Also removes the old recursive invalidate_cascading_view_caches in favor of synchronous collect_cascade_views (single lock acquisition). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ViewCacheState::Computingstate — queries return "not ready" error until precomputation finishesview_chain_performance.mdmitigations Update node docs #1 and Add manual cross-schema transform test #3)State machine
Test plan
cargo clippy --workspace --all-targets -- -D warningscleancargo test --workspace --all-targets— all pass (including existing view chain tests)🤖 Generated with Claude Code