This repository was archived by the owner on May 13, 2026. It is now read-only.
chore(schema): scrub stale FieldBase log strings post-#684 inline - #688
Merged
Conversation
The FieldBase<M> generic was inlined into the four field variants in #684 and deleted, but three tracing log messages in base.rs still used "FieldBase:" as a prefix. Those logs now live inside the free function refresh_field_from_db<M>, so retag the prefix to match the actual call site. Levels and fields preserved; no behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrubs the three stale
"FieldBase: ..."log strings incrates/core/src/schema/types/field/base.rsthat were left over after #684 inlinedFieldBase<M>into the four field variants. These logs now live in the free functionrefresh_field_from_db<M>, so the prefix is retagged to match.tracing::warn!("FieldBase: skipping molecule ref ...→refresh_field_from_db: ...tracing::debug!("FieldBase: resolved molecule via pre-tag ...→refresh_field_from_db: ...tracing::warn!("FieldBase: pre-tag fallback ...→refresh_field_from_db: ...No behavior change. Levels, fields, and message structure preserved.
git grep -n FieldBaseis now clean acrosscrates/core/src/schema/types/field/.Reconciled by /kanban babysit — the originating task agent committed locally but stalled before pushing.