This repository was archived by the owner on May 13, 2026. It is now read-only.
Use .handler_err() in mutation.rs and query.rs - #20
Merged
Conversation
…mat!(...))
mutation.rs and query.rs had 5 match blocks that manually constructed
HandlerError::Internal(format!(...)) on the Err arm. The IntoHandlerError
trait (defined in response.rs) already provides .handler_err("context")
for exactly this purpose — used consistently in other handlers like
get_molecule_history, get_atom_content, and get_process_results.
Replaces match { Ok => ..., Err => HandlerError::Internal(...) } with
flat .handler_err("context")? calls, reducing nesting and line count.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shiba4life
enabled auto-merge (squash)
March 13, 2026 22:45
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
match { Ok => ..., Err => HandlerError::Internal(format!(...)) }blocks with flat.handler_err("context")?calls inmutation.rsandquery.rsIntoHandlerErrortrait already existed inresponse.rsand was used in other handlers (get_molecule_history,get_atom_content,get_process_results) — this makes the pattern consistent across all handler filesTest plan
cargo clippy --workspace --all-targets -- -D warningspassescargo check --workspace --features aws-backendpassescargo test --workspace --all-targetspasses./run.sh --local --local-schema🤖 Generated with Claude Code