This repository was archived by the owner on May 13, 2026. It is now read-only.
chore(fingerprints): Phase 4 cleanup — drop duplicate apple_import side call - #774
Merged
Merged
Conversation
…de call The explicit `ingest_text_signals_batch` call in `run_apple_calendar_import` (the block at the former apple_import.rs:904) is now duplicate: #770 wired `fingerprint_hook::run_after_batch` into `execute_mutations_with_tracking` and `decomposition.rs`, so every calendar-event write already triggers the text extractor automatically. Removes the side-call block (comment + `let attendee_records` binding + `if !attendee_records.is_empty()` dispatch) from `run_apple_calendar_import`. `build_attendee_ingestion_records` is retained because its unit tests remain valid as coverage of the attendee→TextRecordDto transform. Also adds a TODO above `apple_import_photos` noting that face detection is not yet wired into the generic ingest path (requires ONNX inline; separate workstream). Co-Authored-By: Claude <noreply@anthropic.com> https://claude.ai/code/session_01XKFhRS8StBTFqyfjdMdVhE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(a) Side-call de-dup — references #770
#770 wired
fingerprint_hook::run_after_batchinto bothexecute_mutations_with_trackinganddecomposition.rs, making the fingerprint extractor fire automatically after every non-system mutation — including calendar events.run_apple_calendar_import(macOS path) had an explicit side-call toingest_text_signals_batchat the formerapple_import.rs:904that was called out in #770's description as "now duplicate work via the hook — follow-up PR". This PR removes that block:let attendee_records = build_attendee_ingestion_records(&events);if !attendee_records.is_empty()dispatch block that matched/logged the resultbuild_attendee_ingestion_recordsitself is retained — its unit tests (#[cfg(all(test, target_os = "macos"))]) cover the attendee→TextRecordDtotransform and remain valid documentation of that mapping.(b) Apple Photos TODO
Added a single-line
TODOabovepub async fn apple_import_photosnoting that face detection is not yet wired into the generic ingest path. No tracking issue was found (gh issue list --search "face detection apple photos"returned 0 results). The TODO reads:(c) Pre-PR check results
The agent environment does not have credentials to fetch the
file_to_markdownprivate git dependency (it is not served by the local proxy), socargo clippy,cargo test -p fold_db_node --lib, andcargo test --test zero_extractor_yield_testcould not be run locally.The change is a pure deletion of code the PR author explicitly flagged as duplicate, plus a one-line comment addition — no new logic is introduced. CI will run the full check suite with proper credentials.
🤖 Automated cleanup agent triggered by merge of #770.
https://claude.ai/code/session_01XKFhRS8StBTFqyfjdMdVhE
Generated by Claude Code