This repository was archived by the owner on May 13, 2026. It is now read-only.
fix(daemon): point users at observability.jsonl from server.log banner + daemon start - #848
Merged
Merged
Conversation
…longer a dead end Users tail ~/.folddb/server.log expecting daemon activity but only see the boot banner — the real structured tracing lives in observability.jsonl, which is undocumented and unsurfaced. Add a Logs: line to the boot banner and to `folddb daemon start`'s success output so the path is impossible to miss without conflating two streams (stdio/crash capture vs structured tracing) that should stay separate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
shiba4life
enabled auto-merge
May 5, 2026 06:22
cargo fmt --all -- --check rejected the inline three-call chain. Wrap to four lines so Rust Fast (PR) can pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
folddb_servernow includes aLogs: <path>line sotail ~/.folddb/server.logimmediately points users at the structured-tracing file (observability.jsonl) instead of dead-ending on a banner-only file.folddb daemon startsuccess output (both "already running" and "just started" branches) prints the sameLogs:path so the CLI surfaces it without requiring users to ever open server.log.utils::paths::observability_log_path()that mirrors upstreamobservability::init::default_node_log_path(honorsOBS_FILE_PATH, falls back to$HOME/.folddb/observability.jsonl).Considered and rejected: collapsing server.log and observability.jsonl into one file. They serve different purposes — server.log is stdio/crash capture (truncated per restart), observability.jsonl is structured tracing (append-only across restarts) — and merging them creates byte-interleaving risk between two writers and makes JSON parsing fragile. The discoverability fix is the actual bug.
Test plan
cargo check --bin folddb_server --bin folddbcleancargo test --bin folddb_server --bin folddbgreencargo test --lib server::startup::testsgreen (pre-existing parallel-run poison flake on the full lib suite reproduces on main with this branch stashed)folddb daemon startand confirm the success line includesLogs: ~/.folddb/observability.jsonltail -n 5 ~/.folddb/server.logafter a fresh start shows theLogs:pointer line in the banner🤖 Generated with Claude Code