This repository was archived by the owner on May 13, 2026. It is now read-only.
chore(apple-import): delete unused build_attendee_ingestion_records - #952
Merged
Conversation
The function and its macOS-gated test module were never wired into the calendar import path — `run_apple_calendar_import` ingests calendar events via `cal::to_json_records` only, never via the text-fingerprint pipeline. On macOS clean builds the orphan triggered `warning: function is never used` on every cargo build during dogfood sessions. Wiring it in would require picking a `source_schema` for the attendee text-signal pipeline — a schema decision out of scope for this cleanup. Linux CI was already silent (the function was cfg-gated to macOS), so deletion is a no-op there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the orphaned
build_attendee_ingestion_recordsfunction insrc/server/routes/apple_import.rs. It was never wired intorun_apple_calendar_import(which usescal::to_json_recordsinstead) and produced awarning: function is never usedon every macOS dogfood build.Wiring it in would require picking a
source_schemafor the attendee text-signal pipeline — out of scope for this cleanup. Linux CI was already silent (cfg-gated), so deletion is a no-op there.Closes kanban task
ae051.Test plan
cargo buildon macOS → nonever usedwarningcargo clippy --workspace --all-targets -- -D warnings