Skip to content
This repository was archived by the owner on Jul 24, 2026. It is now read-only.

Implement complete mcp server detection and quarantine read/writer daemon#2

Merged
dimitriosGX merged 5 commits into
masterfrom
dk-quar
Jul 13, 2026
Merged

Implement complete mcp server detection and quarantine read/writer daemon#2
dimitriosGX merged 5 commits into
masterfrom
dk-quar

Conversation

@dimitriosGX

Copy link
Copy Markdown
Contributor

No description provided.

dimitriosGX and others added 2 commits July 10, 2026 16:23
Adding the `armed` param pushed enroll to 8 args. It's a flat list of
enrollment inputs (matching reconcile_once, which already allows this);
grouping into a struct isn't worth it. Allow the lint.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

dimitriosGX and others added 3 commits July 10, 2026 16:39
The workspace wasn't formatted with stock `cargo fmt`, so the CI `rustfmt`
job (cargo fmt --all -- --check on @stable) was failing. Apply canonical
formatting across all crates. No behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@dimitriosGX
dimitriosGX requested a review from IliaMManolov July 13, 2026 10:37
@IliaMManolov

Copy link
Copy Markdown
Collaborator

Whoosh that's a lot of changes. Let me see if I can build and run this + the desktop app and I think that's good enough for me to approve

@dimitriosGX

Copy link
Copy Markdown
Contributor Author

Whoosh that's a lot of changes. Let me see if I can build and run this + the desktop app and I think that's good enough for me to approve

It can wait no worries. I did not test E2E really yet after pushing some of the last fixes on desktop and I am also preparing the Windows part which has some work.

@IliaMManolov

Copy link
Copy Markdown
Collaborator

Nice, all works and builds. A few findings:

mcp-detector-lib must be called detectord actually. Then if you run the .app in dist the location of the detectord CLI is in desktop/dist/mac-arm64/Edison Watch.app/Contents/Resources/bin/edison-detectord. Does this remove the nagging from Chokidar scanning files, I have a feeling I didn't see it but also it might have already been dismissed previously.

Anyways, looks good. Both are good to merge.

@IliaMManolov IliaMManolov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment (dunno why I can't approve from comment instead of having to go to the review pane)

@dimitriosGX
dimitriosGX merged commit c6159b7 into master Jul 13, 2026
10 checks passed
@dimitriosGX
dimitriosGX deleted the dk-quar branch July 13, 2026 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants