This repository was archived by the owner on Jul 24, 2026. It is now read-only.
Add linux support#6
Merged
Merged
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Confidence score: 5/5
- Safe to merge after the addressed issues were fixed.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add Linux support with a per-user
systemdservice for the detector daemon. It auto-starts on login, restarts on failure, and falls back cleanly on non-systemddistros.New Features
service::linuxusing a per-user unit at~/.config/systemd/user/edison-detectord.service(selected ontarget_os = "linux").logs/detectord.log, reloads, and enables--now; uninstall disables and removes the unit.ExecStart(--enforceor--no-hooks).systemduser instance is unavailable and returns an actionable message suggestingedison-detectord daemonas a fallback.Bug Fixes
ExecStartto handle spaces and avoidstatus=203/EXEC; added tests to cover this.Written for commit 8bfb028. Summary will update on new commits.