Bump Android Gradle Plugin to 9.3.2 (with Gradle/toolchain updates) - #32
Merged
Conversation
Bumps com.android.application from 8.7.2 to 9.3.2. --- updated-dependencies: - dependency-name: com.android.application dependency-version: 9.3.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Dependabot #18 bumped AGP to 9.3.2 but AGP 9 needs a newer toolchain: - Gradle wrapper 8.9 -> 9.5.0 (AGP 9.3 minimum) - Kotlin (KGP) 2.0.21 -> 2.2.10 (AGP 9 minimum KGP) - compileSdk/targetSdk 35 -> 36 (AGP 9 minimum/supported API) - Opt out of AGP 9 defaults builtInKotlin and newDsl to keep the external org.jetbrains.kotlin.android + kotlin-serialization plugins and classic DSL JDK stays 17 (AGP 9.3 minimum), CI unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NgN7YdfLT41kWnWqe1MPZa
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="gradle/wrapper/gradle-wrapper.properties">
<violation number="1" location="gradle/wrapper/gradle-wrapper.properties:3">
P3: This toolchain bump leaves the repository setup documentation advertising Gradle 8.9, AGP 8.7.x, and SDK 35. Update `README.md` and `CLAUDE.md` so contributors install and use the new Gradle, plugin, and SDK versions.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip |
There was a problem hiding this comment.
P3: This toolchain bump leaves the repository setup documentation advertising Gradle 8.9, AGP 8.7.x, and SDK 35. Update README.md and CLAUDE.md so contributors install and use the new Gradle, plugin, and SDK versions.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At gradle/wrapper/gradle-wrapper.properties, line 3:
<comment>This toolchain bump leaves the repository setup documentation advertising Gradle 8.9, AGP 8.7.x, and SDK 35. Update `README.md` and `CLAUDE.md` so contributors install and use the new Gradle, plugin, and SDK versions.</comment>
<file context>
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip
networkTimeout=10000
validateDistributionUrl=true
</file context>
Miyamura80
added a commit
that referenced
this pull request
Aug 28, 2026
The old CLAUDE.md had drifted stale (it still listed Gradle 8.9 / AGP 8.7 / compileSdk 35, all superseded by #32) and buried the facts a fresh agent actually can't discover by reading code. Cut it to a short, high-signal file and move the procedural detail into a skill. CLAUDE.md now leads with the environment facts that are invisible from the source: no Android SDK in the cloud sandbox (gradle build/lint/test fail locally; CI is the sole gate), the per-call-site lint MissingPermission rule, and that trifecta/policy classification lives in the edison-watch repo. Points at libs.versions.toml as the version source of truth instead of copying numbers that rot. New .claude/skills/add-mobile-module skill carries the module contract (*Source interface + Android*.kt impl + JVM test), the in-band-error and hex-payload rules, the SecurityException-in-the-same-function lint gotcha, and the JVM scratch-project recipe for verifying module logic without the SDK. Claude-Session: https://claude.ai/code/session_01NgN7YdfLT41kWnWqe1MPZa Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #18.
Dependabot #18 bumped the Android Gradle Plugin from 8.7.2 to 9.3.2 (a major jump) but changed only
agpingradle/libs.versions.toml. AGP 9 raises its required toolchain, so that alone will not build. This PR is based on #18's branch and adds the rest of what AGP 9.3.2 needs.Versions changed and why
com.android.application)compileSdk/targetSdkOther AGP 9 adjustments
android.builtInKotlin=falseandandroid.newDsl=falsetogradle.properties. AGP 9 turns both on by default; built-in Kotlin drops theorg.jetbrains.kotlin.androidplugin and the new DSL is incompatible with it. This project keeps the externalorg.jetbrains.kotlin.android+kotlin-serializationplugins and the classic Android DSL, so it opts out of both (the opt-out is supported through the AGP 9.x line and is slated for removal in AGP 10).Unchanged
.github/workflows/android.ymlneeds no change.minSdkstays 26. NopackagingOptions/lint-DSL/variant-API usage that AGP 9 removed. All sources are Kotlin, andandroid.nonTransitiveRClass=trueis already set.🤖 Generated with Claude Code
https://claude.ai/code/session_01NgN7YdfLT41kWnWqe1MPZa
Generated by Claude Code
Summary by cubic
Upgrades the Android Gradle Plugin from 8.7.2 to 9.3.2 and updates the surrounding toolchain to AGP 9's minimum requirements so the project builds again.
org.jetbrains.kotlin.androidandkotlin-serializationplugins and the classic Android DSL; the opt-out is supported through AGP 9.x and removed in AGP 10.Written for commit c8e2d6d. Summary will update on new commits.