feat(ai-qa): close issues on delivery PASS; cleanup PR head branches

[Hicham Zinalabdin (hichamza)]

Why

ai-qa was a post-merge agentic review that treated GitHub’s merge as done. Merge is not delivery: GitHub auto-closes linked issues at merge time, auto-deletes heads only on merge (never on close-without-merge), and neither waits for deploy health.

This makes ai-qa own done at two surfaces, matching finishing-a-development-branch (verify success, then clean up only what we own).

What changed

Issue-level

• On delivery PASS, close linked issues (consumers should turn off GitHub auto-close-on-merge).
• On FAIL, leave them open; reopen if GitHub already auto-closed them.
• On issues.closed, reopen if the issue was closed before delivery (linked merged PR without ✓ /ai-qa), unless this action closed it or state_reason is not_planned.

PR-level

• Merged + PASS → delete head branch.
• Merged + FAIL → keep the branch.
• Closed without merge → delete head (the GitHub-native gap).
• Never delete the default branch, a fork head, or a ref still used by another open PR. 404 = already gone; 403 warns; job stays green. Delete uses GITHUB_TOKEN (contents: write), not the App token.

Policy lives in tested ai-qa/lib/cleanup.js. Unit CI now also runs ai-qa/lib/**/*.test.js.

Caller workflows should add:

on:
  push:
    branches: [main]
  pull_request:
    types: [closed]
  issues:
    types: [closed]
permissions:
  contents: write
  pull-requests: write
  issues: write

And disable Settings → General → Issues → Auto-close issues with merged linked pull requests.

Out of scope

The optional Claude review is unchanged (still color on the report). No tag/deployment deletion.

  

✅ ai-qa: PASS

Deploy health: healthy · findings P0 0 · P1 0 · P2 0 · P3 0

Last updated by ai-qa · QA run

[mtm-bot]

✅ ai-qa: PASS

Merge commit 090a4a7ccda9

Signal	Result
Deploy health (https://raw.githubusercontent.com/EdulyCom/github-actions/main/README.md)	✅ healthy
QA review	⚠️ did not run — reporting deploy-health signal only
Head branch	will delete hz/ai-qa-issue-pr-hygiene-e361

Posted by mtm-bot[bot] · workflow run