Add persons who are neither student nor teacher (#30)#31
Merged
Conversation
Deploying sql-validator with
|
| Latest commit: |
627d81a
|
| Status: | ⚡️ Build in progress... |
Edwinexd
force-pushed
the
fix/issue-30-neither-both-persons
branch
from
481ce7c to
df7bfd4
Compare
Reconcile the 4 neither-persons onto the merged PG+RA master: the oracle now carries both the new persons and the pgQuery overrides, and all 6 data variants (en/sv/de x sqlite/pg) are regenerated. Verified: Person 25 / Student 17 / Teacher 6 / neither 4 / both 2, 0 generation errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add persons who are neither student nor teacher
Closes #30 (data-only change).
Until now every Person was a Student or a Teacher (
neither = 0), which let "join Teacher" shortcut solutions validate as correct on the not-in-role questions. This adds 4 persons who are neither student nor teacher so those shortcuts now produce a wrong result.What changed
data/oracle.enc— 4 newOraclePersonentries (isStudent: false,isTeacher: false), appended at the end so existing course-instance / participation indices are untouched.languages/{en,sv,de}.ts— appended 4 entries to each pack's positionalpersonIds/postalCodes/phonesarrays (verified all three at 25, in index order).public/languages/{en,sv,de}/{questionpool.json,data.sqlite3}.Verified (English DB)
Person 25 · Student 17 · Teacher 6 · neither 4 · both 2Blast radius
13 / 110 questions shift result counts (all Person-related): Q1A/B/E, Q2A–J, Q11A 15→19.