Support SQL Server in cluster SqlMessageStorage#6441
Draft
sbking wants to merge 4 commits into
Draft
Conversation
…luster SqlMessageStorage
🦋 Changeset detectedLatest commit: 9ad877d The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SqlMessageStoragecontains SQL Server-specific DDL and query paths, but adding anmssqlleg to the existing storage suite exposes four SQL Server errors.FOR UPDATE, which is not valid T-SQL in these queriesUNIQUEconstraints with filtered unique indexes so NULL message and reply keys keep the same semantics as the other dialectsTEXTcolumns withNVARCHAR(MAX)so NULL parameters can be inserted (error 206 otherwise)MERGEpath to returninserted.id, then read the previous reply when no row was inserted, since SQL Server rejects subqueries inOUTPUT(error 10705)Fresh databases use the corrected DDL. An idempotent
0003_mssql_schema_fixesmigration updates existing SQL Server schemas and is a no-op on other dialects. The shared suite gains a 30sdescribetimeout (as intest/fixtures/rpc-e2e.ts) because concurrent per-test migrations against the SQL Server container can exceed the 5s default.Testing
pnpm vitest run packages/platform-node/test/cluster/SqlMessageStorage.test.ts packages/platform-node/test/cluster/SqlMessageStorageMssql.test.ts(39/39 against SQL Server 2022; also green against SQL Server 2025)pnpm checkpnpm lint