Add DateTime.toEpochSeconds - #6470
Closed
coyaSONG wants to merge 1 commit into
Closed
Conversation
🦋 Changeset detectedLatest commit: d582a14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
@coyaSONG Version 3 is now in feature freeze as we prepare the release of v4 |
IMax153
added
3.0
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Adds
DateTime.toEpochSecondsfor obtaining whole seconds since the Unix epoch. The conversion floors the millisecond timestamp so instants before the epoch retain the conventional Unix timestamp semantics (for example,-1millisecond becomes-1second rather than0).The change includes regression coverage for fractional positive and pre-epoch timestamps, along with the required patch changeset. It was validated with:
pnpm vitest packages/effect/test/DateTime.test.ts --runpnpm lint-fixpnpm checkpnpm buildpnpm docgengit diff --checkImplementation prepared with OpenAI Codex. No human code review has been performed.
Related