Skip to content

Validate Cron.make field restrictions#6474

Merged
fubhy merged 2 commits into
mainfrom
cron/make-validation
Jul 17, 2026
Merged

Validate Cron.make field restrictions#6474
fubhy merged 2 commits into
mainfrom
cron/make-validation

Conversation

@fubhy

@fubhy fubhy commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary

  • validate explicit Cron field restrictions before building lookup tables
  • normalize weekday 7 to Sunday (0) consistently with parsing
  • add focused constructor, matching, and stepping coverage

Testing

  • pnpm lint-fix
  • pnpm test packages/effect/test/Cron.test.ts
  • pnpm check

@github-project-automation github-project-automation Bot moved this to Discussion Ongoing in PR Backlog Jul 17, 2026
@changeset-bot

changeset-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 922e266

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
effect Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/vitest Patch
@effect/ai-anthropic Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

File Name Current Size Previous Size Difference
basic.ts 6.58 KB 6.58 KB 0.00 KB (0.00%)
batching.ts 9.19 KB 9.19 KB 0.00 KB (0.00%)
brand.ts 6.14 KB 6.14 KB 0.00 KB (0.00%)
cache.ts 9.83 KB 9.83 KB 0.00 KB (0.00%)
config.ts 18.80 KB 18.80 KB 0.00 KB (0.00%)
differ.ts 17.02 KB 17.02 KB 0.00 KB (0.00%)
http-client.ts 20.50 KB 20.50 KB 0.00 KB (0.00%)
logger.ts 10.17 KB 10.17 KB 0.00 KB (0.00%)
metric.ts 8.44 KB 8.44 KB 0.00 KB (0.00%)
optic.ts 7.35 KB 7.35 KB 0.00 KB (0.00%)
pubsub.ts 14.01 KB 14.01 KB 0.00 KB (0.00%)
queue.ts 11.01 KB 11.01 KB 0.00 KB (0.00%)
schedule.ts 10.21 KB 10.21 KB 0.00 KB (0.00%)
schema-class.ts 17.86 KB 17.86 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 4.06 KB 4.06 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 27.25 KB 27.25 KB 0.00 KB (0.00%)
schema-string-transformation.ts 12.52 KB 12.52 KB 0.00 KB (0.00%)
schema-string.ts 10.19 KB 10.19 KB 0.00 KB (0.00%)
schema-template-literal.ts 14.19 KB 14.19 KB 0.00 KB (0.00%)
schema-toArbitraryLazy.ts 20.65 KB 20.65 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 21.23 KB 21.23 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 17.84 KB 17.84 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 17.72 KB 17.72 KB 0.00 KB (0.00%)
schema-toFormatter.ts 17.57 KB 17.57 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 20.13 KB 20.13 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 18.09 KB 18.09 KB 0.00 KB (0.00%)
schema.ts 17.14 KB 17.14 KB 0.00 KB (0.00%)
stm.ts 11.95 KB 11.95 KB 0.00 KB (0.00%)
stream.ts 9.20 KB 9.20 KB 0.00 KB (0.00%)

@fubhy
fubhy enabled auto-merge (squash) July 17, 2026 17:36
@fubhy
fubhy merged commit f3fbae8 into main Jul 17, 2026
14 checks passed
@fubhy
fubhy deleted the cron/make-validation branch July 17, 2026 17:37
@github-project-automation github-project-automation Bot moved this from Discussion Ongoing to Done in PR Backlog Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant