Fix Schema JSON stringification of undefined

packages/effect/src/SchemaGetter.ts

@@ -1015,13 +1015,10 @@ type StringifyJsonOptions = {
  * **Details**
  *
  * - Skips `None` inputs.
- * - On thrown stringify failures, such as circular references, fails with
+ * - If `JSON.stringify` throws or returns `undefined`, fails with
  *   `SchemaIssue.InvalidValue`.
  * - Supports optional `replacer` and `space` options, matching
  *   `JSON.stringify`.
- * - If `JSON.stringify` returns `undefined`, such as for `undefined`,
- *   functions, symbols, or a replacer that removes the root value, that
- *   `undefined` result is returned rather than converted into an `Issue`.
  *
  * **Example** (Stringifying JSON)
  *
@@ -1040,7 +1037,13 @@ type StringifyJsonOptions = {
 export function stringifyJson(options?: StringifyJsonOptions): Getter<string, unknown> {
   return onSome((input) =>
     Effect.try({
-      try: () => Option.some(JSON.stringify(input, options?.replacer, options?.space)),
+      try: () => {
+        const output = JSON.stringify(input, options?.replacer, options?.space)
+        if (output === undefined) {
+          throw new TypeError("Value cannot be represented as JSON")
+        }
+        return Option.some(output)
+      },
       catch: (e) => new SchemaIssue.InvalidValue(Option.some(input), { message: globalThis.String(e) })
     })
   )

packages/effect/test/schema/SchemaGetter.test.ts

@@ -1,6 +1,5 @@
-import { assert } from "@effect/vitest"
+import { assert, describe, it } from "@effect/vitest"
 import { DateTime, Effect, Option, Result, SchemaGetter } from "effect"
-import { describe, it } from "vitest"
 import { assertSome, deepStrictEqual } from "../utils/assert.ts"
 
 function makeAsserts<T, E>(getter: SchemaGetter.Getter<T, E>) {
@@ -16,6 +15,12 @@ function makeAsserts<T, E>(getter: SchemaGetter.Getter<T, E>) {
 }
 
 describe("SchemaGetter", () => {
+  it.effect("stringifyJson fails when JSON.stringify returns undefined", () =>
+    SchemaGetter.stringifyJson().run(Option.some(undefined), {}).pipe(
+      Effect.flip,
+      Effect.map((issue) => assert.strictEqual(issue._tag, "InvalidValue"))
+    ))
+
   it("map", () => {
     const getter = SchemaGetter.succeed(1).map((t) => t + 1)
     const result = Effect.runSync(getter.run(Option.some(1), {}))