Preserve accessors with loose object spread - #6659
Conversation
🦋 Changeset detectedLatest commit: 494bfda The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis change reorders shared prototype spreads and local accessors across core Effect, AI, SQL, and IndexedDB implementations. It also adds patch changesets for ChangesPrototype ordering updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Comment |
Bundle Size Analysis
|
Summary
effectand@effect/platform-browserVerification
pnpm lintpnpm checkpnpm --filter effect test --run test/Exit.test.ts test/unstable/ai/Model.test.ts test/unstable/sql/Statement.test.tspnpm --filter @effect/platform-browser test --run test/IndexedDbDatabase.test.ts test/IndexedDbQueryBuilder.test.tsmakeExitreorderpackages/**/srcA native
Object.getOwnPropertyDescriptorassertion was not added because it also passes with the broken ordering: standard object spread preserves the accessor in either position, while only Babel's loose transform loses it.Consumer Workaround
Until this reaches a release, consumers can run a strict spread transform before
babel-preset-expo:Closes EFF-114
Fixes #6578
Summary by CodeRabbit