EFF-123: Surface unknown OpenAI-compatible stream events - #6667
Conversation
🦋 Changeset detectedLatest commit: 7c903b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughChat completion SSE decoding now preserves valid schema-mismatched payloads as ChangesOpenAI-compatible streaming
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Provider
participant decodeChatCompletionSseData
participant OpenAiLanguageModel
participant streamText
Provider->>decodeChatCompletionSseData: Send SSE JSON chunk
decodeChatCompletionSseData-->>OpenAiLanguageModel: ChatCompletionChunk or UnknownChatCompletionEvent
OpenAiLanguageModel->>OpenAiLanguageModel: Skip translation for unknown event
OpenAiLanguageModel-->>streamText: Continue stream processing
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Comment |
Bundle Size Analysis
|
Summary
UnknownChatCompletionEventTesting
pnpm --filter @effect/ai-openai-compat test --run test/OpenAiClient.test.ts test/OpenAiLanguageModel.test.tspnpm --filter @effect/ai-openai-compat checkpnpm checkpnpm lintCloses EFF-123
Closes #6346
Summary by CodeRabbit
New Features
UnknownChatCompletionEventdata.Bug Fixes