Add Deno Redis integration - #6686
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: f61108a The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a native Deno Redis integration backed by ChangesDeno Redis integration
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Application
participant DenoRedisLayer
participant RedisClient
participant PersistenceSuite
Application->>DenoRedisLayer: Configure host, port, or URL
DenoRedisLayer->>RedisClient: Acquire scoped client
PersistenceSuite->>RedisClient: Execute persistence commands
RedisClient-->>PersistenceSuite: Return command results
DenoRedisLayer->>RedisClient: Close client on scope end
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/platform-deno/src/DenoRedis.ts`:
- Around line 54-64: Update the Effect.tryPromise callback around connect so it
accepts the provided AbortSignal and passes it into connect for both the
localhost and parsed-URL branches. Merge it with any caller-provided signal in
connectOptions, preserving existing connection options while ensuring
interruption cancels the handshake.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4a3fdd2e-4785-4a49-8723-5e4d5afc9a77
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
.changeset/eff-151-deno-redis.mdpackages/platform-deno/package.jsonpackages/platform-deno/src/DenoRedis.tspackages/platform-deno/src/index.tspackages/platform-deno/test/DenoRedis.test.ts
tim-smart
force-pushed
the
agent/codex-engineer/71b23293
branch
from
July 28, 2026 06:11
e500693 to
9331205
Compare
Contributor
Bundle Size Analysis
|
tim-smart
commented
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@db/redisTesting
pnpm lint-fixpnpm checkpnpm --filter @effect/platform-deno checkdeno task test --run packages/platform-deno/test/DenoRedis.test.tsCloses EFF-151
Summary by CodeRabbit
DenoRedissupport.layerandlayerConfig.AUTHcredential behavior.