Improve configuration - #6701
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 42e0911 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughThe PR separates TypeScript package and test projects, broadens test discovery, centralizes Vitest exclusions, blocks explicit ChangesWorkspace configuration and test execution
Package exports and tooling
Runtime annotations and tests
Configuration consistency
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.5)packages/tools/oxc/oxlintrc.jsonFile contains syntax errors that prevent linting: Line 10: Expected a property but instead found '// Effect custom rules'.; Line 11: End of file expected; Line 11: End of file expected; Line 11: End of file expected; Line 11: End of file expected; Line 12: End of file expected; Line 12: End of file expected; Line 12: End of file expected; Line 20: End of file expected; Line 21: End of file expected; Line 21: End of file expected; Line 21: End of file expected; Line 21: End of file expected; Line 22: End of file expected; Line 22: End of file expected; Line 22: End of file expected; Line 22: End of file expected; Line 23: End of file expected; Line 23: End of file expected; Line 23: End of file expected; Line 23: End of file expected; Line 24: End of file expected; Line 24: End of file expected; Line 24: End of file expected; Line 24: End of file expected; Line 27: End of file expected; Line 27: End of file expected; Line 27: End of file expected; Line 29: End of file expected; Line 30: ... [truncated 4646 characters] ... 70: End of file expected; Line 70: End of file expected; Line 71: End of file expected; Line 71: End of file expected; Line 71: End of file expected; Line 71: End of file expected; Line 72: End of file expected; Line 72: End of file expected; Line 72: End of file expected; Line 72: End of file expected; Line 73: End of file expected; Line 73: End of file expected; Line 73: End of file expected; Line 73: End of file expected; Line 74: End of file expected; Line 74: End of file expected; Line 74: End of file expected; Line 74: End of file expected; Line 75: End of file expected; Line 75: End of file expected; Line 75: End of file expected; Line 78: End of file expected; Line 79: End of file expected; Line 79: End of file expected; Line 79: End of file expected; Line 83: End of file expected Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
fubhy
force-pushed
the
improve-cfg
branch
2 times, most recently
from
July 28, 2026 15:33
e9b3bde to
062a5ae
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/effect/package.json`:
- Around line 51-54: Update the workspace exports map in
packages/effect/package.json to mirror the publishConfig.exports null entries
for ./unstable/cli/internal/* and ./unstable/cluster/internal/*, keeping local
and published export behavior consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c84d553f-0778-4206-8044-4c747b9f32b7
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (97)
.changeset/slimy-melons-admire.mdai-docs/tsconfig.jsonpackage.jsonpackages/ai/anthropic/package.jsonpackages/ai/anthropic/tsconfig.jsonpackages/ai/openai-compat/package.jsonpackages/ai/openai-compat/tsconfig.jsonpackages/ai/openai/package.jsonpackages/ai/openai/tsconfig.jsonpackages/ai/openrouter/package.jsonpackages/ai/openrouter/tsconfig.jsonpackages/atom/react/package.jsonpackages/atom/react/tsconfig.jsonpackages/atom/solid/package.jsonpackages/atom/solid/tsconfig.jsonpackages/atom/solid/vitest.config.tspackages/atom/vue/package.jsonpackages/atom/vue/tsconfig.jsonpackages/effect/package.jsonpackages/effect/test/Formatter.test.tspackages/effect/test/cluster/Entity.test.tspackages/effect/test/schema/representation/fromJson.test.tspackages/effect/test/unstable/cli/Primitive.test.tspackages/effect/tsconfig.jsonpackages/opentelemetry/package.jsonpackages/opentelemetry/tsconfig.jsonpackages/platform-browser/package.jsonpackages/platform-browser/tsconfig.jsonpackages/platform-bun/package.jsonpackages/platform-bun/tsconfig.jsonpackages/platform-deno/package.jsonpackages/platform-deno/tsconfig.jsonpackages/platform-node-shared/package.jsonpackages/platform-node-shared/tsconfig.jsonpackages/platform-node/package.jsonpackages/platform-node/tsconfig.jsonpackages/sql/clickhouse/package.jsonpackages/sql/clickhouse/tsconfig.jsonpackages/sql/d1/package.jsonpackages/sql/d1/tsconfig.jsonpackages/sql/libsql/package.jsonpackages/sql/libsql/tsconfig.jsonpackages/sql/mssql/package.jsonpackages/sql/mssql/tsconfig.jsonpackages/sql/mysql2/package.jsonpackages/sql/mysql2/tsconfig.jsonpackages/sql/pg/package.jsonpackages/sql/pg/tsconfig.jsonpackages/sql/pglite/package.jsonpackages/sql/pglite/tsconfig.jsonpackages/sql/sqlite-bun/package.jsonpackages/sql/sqlite-bun/tsconfig.jsonpackages/sql/sqlite-do/package.jsonpackages/sql/sqlite-do/tsconfig.jsonpackages/sql/sqlite-node/package.jsonpackages/sql/sqlite-node/tsconfig.jsonpackages/sql/sqlite-react-native/package.jsonpackages/sql/sqlite-react-native/tsconfig.jsonpackages/sql/sqlite-wasm/package.jsonpackages/sql/sqlite-wasm/tsconfig.jsonpackages/tools/ai-codegen/package.jsonpackages/tools/ai-codegen/tsconfig.jsonpackages/tools/ai-docgen/package.jsonpackages/tools/ai-docgen/tsconfig.jsonpackages/tools/api-diff/package.jsonpackages/tools/api-diff/tsconfig.jsonpackages/tools/bundle/package.jsonpackages/tools/bundle/tsconfig.fixtures.jsonpackages/tools/bundle/tsconfig.jsonpackages/tools/bundle/tsconfig.src.jsonpackages/tools/docgen/package.jsonpackages/tools/docgen/test/Checker.test.tspackages/tools/docgen/tsconfig.jsonpackages/tools/jsdocs/package.jsonpackages/tools/jsdocs/tsconfig.jsonpackages/tools/openapi-generator/tsconfig.jsonpackages/tools/oxc/package.jsonpackages/tools/oxc/src/oxlint/rules/jsdocs.tspackages/tools/oxc/src/oxlint/rules/no-bigint-literals.tspackages/tools/oxc/src/oxlint/rules/no-import-from-barrel-package.tspackages/tools/oxc/src/oxlint/rules/no-js-extension-imports.tspackages/tools/oxc/src/oxlint/rules/no-opaque-instance-fields.tspackages/tools/oxc/src/oxlint/rules/no-unused-internal.tspackages/tools/oxc/tsconfig.jsonpackages/tools/utils/package.jsonpackages/tools/utils/tsconfig.jsonpackages/vitest/package.jsonpackages/vitest/tsconfig.jsonscratchpad/tsconfig.jsonscripts/tsconfig.jsontsconfig.base.jsontsconfig.jsontsconfig.packages.jsontsconfig.tests.jsontstyche.jsonvitest.config.tsvitest.shared.ts
🚧 Files skipped from review as they are similar to previous changes (45)
- packages/ai/openrouter/tsconfig.json
- packages/platform-deno/tsconfig.json
- packages/ai/anthropic/tsconfig.json
- packages/platform-browser/tsconfig.json
- packages/sql/sqlite-do/tsconfig.json
- packages/opentelemetry/tsconfig.json
- scratchpad/tsconfig.json
- packages/sql/sqlite-wasm/tsconfig.json
- packages/tools/bundle/tsconfig.json
- packages/tools/ai-docgen/tsconfig.json
- packages/sql/pg/tsconfig.json
- packages/sql/sqlite-node/tsconfig.json
- tsconfig.base.json
- packages/tools/jsdocs/tsconfig.json
- ai-docs/tsconfig.json
- packages/sql/pglite/tsconfig.json
- packages/atom/react/tsconfig.json
- packages/vitest/tsconfig.json
- packages/ai/openai-compat/tsconfig.json
- packages/ai/openai/tsconfig.json
- packages/sql/mysql2/tsconfig.json
- packages/platform-node-shared/tsconfig.json
- packages/sql/sqlite-bun/tsconfig.json
- packages/sql/sqlite-react-native/tsconfig.json
- scripts/tsconfig.json
- packages/sql/d1/tsconfig.json
- packages/tools/bundle/tsconfig.fixtures.json
- packages/tools/api-diff/tsconfig.json
- packages/sql/clickhouse/tsconfig.json
- packages/tools/oxc/tsconfig.json
- tsconfig.packages.json
- packages/tools/docgen/tsconfig.json
- packages/tools/utils/tsconfig.json
- packages/atom/solid/tsconfig.json
- packages/sql/mssql/tsconfig.json
- packages/platform-node/tsconfig.json
- packages/sql/libsql/tsconfig.json
- packages/effect/tsconfig.json
- packages/tools/openapi-generator/tsconfig.json
- packages/platform-bun/tsconfig.json
- tsconfig.json
- packages/tools/bundle/tsconfig.src.json
- vitest.config.ts
- packages/effect/test/unstable/cli/Primitive.test.ts
- tsconfig.tests.json
github-project-automation
Bot
moved this from Discussion Ongoing
to Waiting on Author
in PR Backlog
fubhy
force-pushed
the
improve-cfg
branch
2 times, most recently
from
July 28, 2026 15:49
0020ea2 to
c70fe1a
Compare
Contributor
Bundle Size Analysis
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/effect/package.json`:
- Around line 54-55: Restore the top-level null export entries for the unstable
internal paths in the package exports configuration, ensuring both workspace
exports and publishConfig.exports block ./unstable/cli/internal/* and
./unstable/cluster/internal/* consistently. Preserve the existing ./internal/*
and ./index entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4227e9ac-9790-4182-b079-befdb01322f1
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (104)
.changeset/slimy-melons-admire.mdai-docs/tsconfig.jsonpackage.jsonpackages/ai/anthropic/package.jsonpackages/ai/anthropic/tsconfig.jsonpackages/ai/openai-compat/package.jsonpackages/ai/openai-compat/tsconfig.jsonpackages/ai/openai/package.jsonpackages/ai/openai/tsconfig.jsonpackages/ai/openrouter/package.jsonpackages/ai/openrouter/tsconfig.jsonpackages/atom/react/package.jsonpackages/atom/react/tsconfig.jsonpackages/atom/solid/package.jsonpackages/atom/solid/tsconfig.jsonpackages/atom/solid/vitest.config.tspackages/atom/vue/package.jsonpackages/atom/vue/tsconfig.jsonpackages/effect/package.jsonpackages/effect/src/unstable/cluster/Sharding.tspackages/effect/test/Formatter.test.tspackages/effect/test/cluster/Entity.test.tspackages/effect/test/schema/representation/fromJson.test.tspackages/effect/test/unstable/cli/Primitive.test.tspackages/effect/tsconfig.jsonpackages/opentelemetry/package.jsonpackages/opentelemetry/tsconfig.jsonpackages/platform-browser/package.jsonpackages/platform-browser/tsconfig.jsonpackages/platform-bun/package.jsonpackages/platform-bun/tsconfig.jsonpackages/platform-deno/package.jsonpackages/platform-deno/tsconfig.jsonpackages/platform-node-shared/package.jsonpackages/platform-node-shared/src/internal/utils.tspackages/platform-node-shared/tsconfig.jsonpackages/platform-node/package.jsonpackages/platform-node/src/NodeClusterSocket.tspackages/platform-node/src/NodeHttpClient.tspackages/platform-node/test/NodeSocket.test.tspackages/platform-node/tsconfig.jsonpackages/sql/clickhouse/package.jsonpackages/sql/clickhouse/tsconfig.jsonpackages/sql/d1/package.jsonpackages/sql/d1/tsconfig.jsonpackages/sql/libsql/package.jsonpackages/sql/libsql/tsconfig.jsonpackages/sql/mssql/package.jsonpackages/sql/mssql/tsconfig.jsonpackages/sql/mysql2/package.jsonpackages/sql/mysql2/tsconfig.jsonpackages/sql/pg/package.jsonpackages/sql/pg/tsconfig.jsonpackages/sql/pglite/package.jsonpackages/sql/pglite/tsconfig.jsonpackages/sql/sqlite-bun/package.jsonpackages/sql/sqlite-bun/tsconfig.jsonpackages/sql/sqlite-do/package.jsonpackages/sql/sqlite-do/tsconfig.jsonpackages/sql/sqlite-node/package.jsonpackages/sql/sqlite-node/tsconfig.jsonpackages/sql/sqlite-react-native/package.jsonpackages/sql/sqlite-react-native/tsconfig.jsonpackages/sql/sqlite-wasm/package.jsonpackages/sql/sqlite-wasm/tsconfig.jsonpackages/tools/ai-codegen/package.jsonpackages/tools/ai-codegen/tsconfig.jsonpackages/tools/ai-docgen/package.jsonpackages/tools/ai-docgen/tsconfig.jsonpackages/tools/api-diff/package.jsonpackages/tools/api-diff/tsconfig.jsonpackages/tools/bundle/package.jsonpackages/tools/bundle/tsconfig.fixtures.jsonpackages/tools/bundle/tsconfig.jsonpackages/tools/bundle/tsconfig.src.jsonpackages/tools/docgen/package.jsonpackages/tools/docgen/test/Checker.test.tspackages/tools/docgen/tsconfig.jsonpackages/tools/jsdocs/package.jsonpackages/tools/jsdocs/tsconfig.jsonpackages/tools/openapi-generator/tsconfig.jsonpackages/tools/oxc/oxlintrc.jsonpackages/tools/oxc/package.jsonpackages/tools/oxc/src/oxlint/rules/jsdocs.tspackages/tools/oxc/src/oxlint/rules/no-bigint-literals.tspackages/tools/oxc/src/oxlint/rules/no-import-from-barrel-package.tspackages/tools/oxc/src/oxlint/rules/no-js-extension-imports.tspackages/tools/oxc/src/oxlint/rules/no-opaque-instance-fields.tspackages/tools/oxc/src/oxlint/rules/no-unused-internal.tspackages/tools/oxc/test/utils.tspackages/tools/oxc/tsconfig.jsonpackages/tools/utils/package.jsonpackages/tools/utils/tsconfig.jsonpackages/vitest/package.jsonpackages/vitest/tsconfig.jsonscratchpad/tsconfig.jsonscripts/tsconfig.jsontsconfig.base.jsontsconfig.jsontsconfig.packages.jsontsconfig.tests.jsontstyche.jsonvitest.config.tsvitest.shared.ts
💤 Files with no reviewable changes (1)
- packages/atom/solid/vitest.config.ts
🚧 Files skipped from review as they are similar to previous changes (87)
- packages/tools/jsdocs/tsconfig.json
- packages/atom/vue/tsconfig.json
- tsconfig.base.json
- scratchpad/tsconfig.json
- packages/sql/sqlite-wasm/tsconfig.json
- packages/tools/ai-codegen/tsconfig.json
- packages/ai/openrouter/tsconfig.json
- packages/opentelemetry/tsconfig.json
- tstyche.json
- packages/sql/sqlite-react-native/tsconfig.json
- packages/tools/bundle/tsconfig.json
- packages/sql/mssql/tsconfig.json
- tsconfig.packages.json
- packages/platform-node-shared/src/internal/utils.ts
- packages/sql/mssql/package.json
- .changeset/slimy-melons-admire.md
- packages/sql/pglite/tsconfig.json
- packages/tools/api-diff/tsconfig.json
- packages/sql/mysql2/tsconfig.json
- packages/tools/bundle/tsconfig.src.json
- packages/tools/ai-docgen/tsconfig.json
- packages/tools/openapi-generator/tsconfig.json
- packages/sql/clickhouse/tsconfig.json
- packages/ai/openai-compat/package.json
- packages/ai/openrouter/package.json
- packages/platform-bun/tsconfig.json
- packages/tools/jsdocs/package.json
- packages/effect/test/Formatter.test.ts
- packages/effect/tsconfig.json
- packages/effect/test/schema/representation/fromJson.test.ts
- packages/platform-browser/tsconfig.json
- packages/atom/react/tsconfig.json
- packages/ai/openai-compat/tsconfig.json
- packages/tools/ai-codegen/package.json
- packages/sql/pg/tsconfig.json
- packages/tools/ai-docgen/package.json
- packages/sql/d1/tsconfig.json
- packages/ai/anthropic/package.json
- packages/sql/sqlite-do/package.json
- packages/effect/test/unstable/cli/Primitive.test.ts
- packages/atom/vue/package.json
- scripts/tsconfig.json
- packages/sql/sqlite-bun/package.json
- packages/tools/oxc/tsconfig.json
- packages/tools/utils/tsconfig.json
- packages/ai/openai/package.json
- packages/sql/pglite/package.json
- packages/sql/d1/package.json
- packages/opentelemetry/package.json
- packages/tools/docgen/tsconfig.json
- packages/sql/libsql/package.json
- packages/sql/sqlite-react-native/package.json
- packages/sql/sqlite-node/package.json
- packages/sql/sqlite-do/tsconfig.json
- packages/tools/oxc/src/oxlint/rules/no-import-from-barrel-package.ts
- packages/sql/sqlite-bun/tsconfig.json
- packages/tools/oxc/src/oxlint/rules/no-js-extension-imports.ts
- packages/atom/solid/package.json
- packages/platform-browser/package.json
- packages/tools/bundle/tsconfig.fixtures.json
- packages/vitest/tsconfig.json
- packages/tools/oxc/src/oxlint/rules/no-unused-internal.ts
- tsconfig.json
- packages/platform-node-shared/package.json
- packages/tools/api-diff/package.json
- packages/effect/test/cluster/Entity.test.ts
- packages/tools/bundle/package.json
- packages/platform-bun/package.json
- packages/effect/src/unstable/cluster/Sharding.ts
- packages/tools/oxc/src/oxlint/rules/no-opaque-instance-fields.ts
- packages/sql/sqlite-wasm/package.json
- packages/tools/utils/package.json
- packages/sql/pg/package.json
- packages/platform-node/tsconfig.json
- packages/atom/solid/tsconfig.json
- packages/tools/oxc/src/oxlint/rules/jsdocs.ts
- packages/platform-node/package.json
- vitest.config.ts
- packages/atom/react/package.json
- vitest.shared.ts
- packages/tools/docgen/package.json
- packages/vitest/package.json
- packages/sql/sqlite-node/tsconfig.json
- package.json
- packages/platform-deno/package.json
- packages/tools/oxc/package.json
- packages/platform-node-shared/tsconfig.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
./indexas non-exported for multiple packages (including publish-time exports).