Add options to Schema.fromJsonString - #6707
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5c3420a The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthrough
ChangesJSON string schema configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant SchemaFromJsonString
participant SchemaTransformationFromJsonString
participant SchemaGetter
Caller->>SchemaFromJsonString: provide schema and JSON options
SchemaFromJsonString->>SchemaTransformationFromJsonString: create configured transformation
SchemaTransformationFromJsonString->>SchemaGetter: configure parseJson and stringifyJson
SchemaGetter-->>Caller: decode or encode JSON string
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Comment |
Contributor
Bundle Size Analysis
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/effect/src/SchemaTransformation.ts`:
- Around line 1621-1623: The JSON option types currently infer only the array
replacer overload. Define a shared replacer type that includes both callback and
array forms, then reuse it for the replacer fields in SchemaTransformation,
Schema, and the corresponding SchemaGetter options; leave reviver and space
typing unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2491bca9-e8d8-4cbc-8a36-149150708f35
📒 Files selected for processing (6)
.changeset/internal-json-string-schema.mdpackages/effect/src/Schema.tspackages/effect/src/SchemaTransformation.tspackages/effect/src/unstable/http/UrlParams.tspackages/effect/test/schema/Schema.test.tspackages/tools/api-diff/src/Json.ts
github-project-automation
Bot
moved this from Discussion Ongoing
to Waiting on Author
in PR Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Schema.fromJsonString.reviver,replacer, andspaceoptions for transformation and pretty-printed output.Schema.fromJsonString(Schema.Unknown).JsonReplacertype forstringifyJsonconfiguration.reviver,replacer, andspacebehavior.