Add Deno services aggregate - #6716
Conversation
🦋 Changeset detectedLatest commit: 1086e78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds an aggregate ChangesDeno services aggregation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/platform-deno/src/DenoServices.ts`:
- Around line 25-32: Update the DenoServices documentation block and the
corresponding layer documentation block to explicitly include the Crypto
service, matching the existing descriptions of the other provided services and
reflecting DenoCrypto.layer.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 98b34ee8-7667-4282-b897-c70a4a1c12cf
📒 Files selected for processing (3)
.changeset/eff-145-deno-services.mdpackages/platform-deno/src/DenoServices.tspackages/platform-deno/src/index.ts
Bundle Size Analysis
|
Summary
DenoServicestype and layerDenoServicesfrom the generated platform-deno barrelValidation
pnpm lint-fixpnpm checkpnpm --filter @effect/platform-deno checkDenoServices.layerpnpm --filter @effect/platform-deno test --runis currently hosted by Node and fails existing native-Deno tests because theDenoglobal is unavailable.Closes EFF-145
Summary by CodeRabbit