Skip to content

Add Deno services aggregate - #6716

Merged
tim-smart merged 2 commits into
mainfrom
agent/codex-engineer/9df66209
Jul 28, 2026
Merged

Add Deno services aggregate#6716
tim-smart merged 2 commits into
mainfrom
agent/codex-engineer/9df66209

Conversation

@tim-smart

@tim-smart tim-smart commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add the aggregate DenoServices type and layer
  • export DenoServices from the generated platform-deno barrel
  • add a patch changeset for the new public API

Validation

  • pnpm lint-fix
  • pnpm check
  • pnpm --filter @effect/platform-deno check
  • Deno runtime smoke test resolving every service from DenoServices.layer

pnpm --filter @effect/platform-deno test --run is currently hosted by Node and fails existing native-Deno tests because the Deno global is unavailable.

Closes EFF-145

Summary by CodeRabbit

  • New Features
    • Added an aggregate Deno “platform services” layer that bundles child process spawning, cryptography, filesystem, path utilities, terminal, and stdio into a single integration point.
    • Re-exported this new Deno services module from the platform package to simplify consumption and composition.

@github-project-automation github-project-automation Bot moved this to Discussion Ongoing in PR Backlog Jul 28, 2026
@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1086e78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@effect/platform-deno Patch
effect Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/vitest Patch
@effect/ai-anthropic Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-slopcop effect-slopcop Bot added 4.0 enhancement New feature or request labels Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f0f2255-93f4-4850-996e-7999f08dd4e5

📥 Commits

Reviewing files that changed from the base of the PR and between c7c7b6c and 1086e78.

📒 Files selected for processing (1)
  • packages/platform-deno/src/DenoServices.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/platform-deno/src/DenoServices.ts

📝 Walkthrough

Walkthrough

Adds an aggregate DenoServices layer combining six Deno-backed services, exports it through the platform package entrypoint, and records a patch changeset for @effect/platform-deno.

Changes

Deno services aggregation

Layer / File(s) Summary
Compose Deno platform services
packages/platform-deno/src/DenoServices.ts
Defines the DenoServices union and composes the child process, crypto, filesystem, path, stdio, and terminal layers.
Expose and release the aggregate layer
packages/platform-deno/src/index.ts, .changeset/eff-145-deno-services.md
Exports the new module from the package entrypoint and adds a patch release changeset.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/platform-deno/src/DenoServices.ts`:
- Around line 25-32: Update the DenoServices documentation block and the
corresponding layer documentation block to explicitly include the Crypto
service, matching the existing descriptions of the other provided services and
reflecting DenoCrypto.layer.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 98b34ee8-7667-4282-b897-c70a4a1c12cf

📥 Commits

Reviewing files that changed from the base of the PR and between 75f340e and c7c7b6c.

📒 Files selected for processing (3)
  • .changeset/eff-145-deno-services.md
  • packages/platform-deno/src/DenoServices.ts
  • packages/platform-deno/src/index.ts

Comment thread packages/platform-deno/src/DenoServices.ts
@github-project-automation github-project-automation Bot moved this from Discussion Ongoing to Waiting on Author in PR Backlog Jul 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

File Name Current Size Previous Size Difference
basic.ts 6.63 KB 6.63 KB 0.00 KB (0.00%)
batching.ts 9.42 KB 9.42 KB 0.00 KB (0.00%)
brand.ts 6.31 KB 6.31 KB 0.00 KB (0.00%)
cache.ts 10.12 KB 10.12 KB 0.00 KB (0.00%)
config.ts 19.90 KB 19.90 KB 0.00 KB (0.00%)
differ.ts 20.03 KB 20.03 KB 0.00 KB (0.00%)
http-client.ts 20.94 KB 20.94 KB 0.00 KB (0.00%)
logger.ts 10.28 KB 10.28 KB 0.00 KB (0.00%)
metric.ts 8.55 KB 8.55 KB 0.00 KB (0.00%)
optic.ts 7.46 KB 7.46 KB 0.00 KB (0.00%)
pubsub.ts 14.26 KB 14.26 KB 0.00 KB (0.00%)
queue.ts 11.09 KB 11.09 KB 0.00 KB (0.00%)
schedule.ts 10.27 KB 10.27 KB 0.00 KB (0.00%)
schema-class.ts 18.86 KB 18.86 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 28.78 KB 28.78 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 25.09 KB 25.09 KB 0.00 KB (0.00%)
schema-string-transformation.ts 12.95 KB 12.95 KB 0.00 KB (0.00%)
schema-string.ts 10.65 KB 10.65 KB 0.00 KB (0.00%)
schema-template-literal.ts 14.85 KB 14.85 KB 0.00 KB (0.00%)
schema-toArbitraryLazy.ts 21.66 KB 21.66 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 24.10 KB 24.10 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 19.00 KB 19.00 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 18.73 KB 18.73 KB 0.00 KB (0.00%)
schema-toFormatter.ts 18.59 KB 18.59 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 22.23 KB 22.23 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 19.27 KB 19.27 KB 0.00 KB (0.00%)
schema.ts 18.12 KB 18.12 KB 0.00 KB (0.00%)
stm.ts 12.05 KB 12.05 KB 0.00 KB (0.00%)
stream.ts 9.37 KB 9.37 KB 0.00 KB (0.00%)

@tim-smart
tim-smart enabled auto-merge (squash) July 28, 2026 21:48
@tim-smart
tim-smart merged commit 897b35c into main Jul 28, 2026
14 of 15 checks passed
@tim-smart
tim-smart deleted the agent/codex-engineer/9df66209 branch July 28, 2026 21:49
@github-project-automation github-project-automation Bot moved this from Waiting on Author to Done in PR Backlog Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.0 enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant