Skip to content

Correct SQL combinator README examples - #6758

Merged
tim-smart merged 1 commit into
v3from
agent/codex-engineer/385c5817
Jul 29, 2026
Merged

Correct SQL combinator README examples#6758
tim-smart merged 1 commit into
v3from
agent/codex-engineer/385c5817

Conversation

@tim-smart

Copy link
Copy Markdown
Contributor

Summary

  • use SQL fragments for the mixed sql.and example
  • align the combinator output comments with PostgreSQL placeholders
  • add a patch changeset for @effect/sql

Validation

  • pnpm lint-fix
  • pnpm test run packages/sql-pg/test/Client.test.ts
  • pnpm check
  • pnpm build
  • pnpm docgen

Closes EFF-206

@github-project-automation github-project-automation Bot moved this to Discussion Ongoing in PR Backlog Jul 29, 2026
@pullfrog

pullfrog Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
  • Read PR summary, diff, and impact files
  • Triage and understand PR changes
  • Decide on specialists needed
  • Draft and submit review

Pullfrog  | View workflow run | via Pullfrog | Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏

@changeset-bot

changeset-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 253b663

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/sql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-slopcop effect-slopcop Bot added 3.0 Used for issues, pull requests, etc. that are relevant for the `v3` branch targeting Effect v3. bug Something isn't working labels Jul 29, 2026
@tim-smart
tim-smart merged commit ad4085e into v3 Jul 29, 2026
9 checks passed
@tim-smart
tim-smart deleted the agent/codex-engineer/385c5817 branch July 29, 2026 23:12
@github-project-automation github-project-automation Bot moved this from Discussion Ongoing to Done in PR Backlog Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0 Used for issues, pull requests, etc. that are relevant for the `v3` branch targeting Effect v3. bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant