Harden JSON-RPC message classification - #6759
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 8bbea67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
ℹ️ One minor inconsistency in the encode path — not blocking.
Reviewed changes
decodeJsonRpcMessage: Switchesmethod,error, andchunkdetection fromintoObject.hasOwn, with a localrequest/responsecast for type narrowing.RpcClientbroadcast handler:requestIdcheck usesObject.hasOwn.RpcServer:tagcheck usesObject.hasOwn, unusedPredicateimport removed.- Tests: Covers clean prototype and inherited
method,error(Defect and Cause variants), andchunkproperties — all correctly ignored.
Note: 1 inline comment(s) dropped because they did not anchor to lines inside the PR diff:
packages/effect/src/unstable/rpc/RpcSerialization.ts:285(RIGHT) — line 285 (RIGHT) is not inside a diff hunk
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Testing
pnpm lint-fixpnpm --filter effect test --run test/rpc/RpcSerialization.test.tspnpm checkCloses EFF-200