Skip to content

Harden v3 cookie attribute validation - #6765

Merged
tim-smart merged 1 commit into
v3from
agent/codex-engineer/959d616c
Jul 29, 2026
Merged

Harden v3 cookie attribute validation#6765
tim-smart merged 1 commit into
v3from
agent/codex-engineer/959d616c

Conversation

@tim-smart

Copy link
Copy Markdown
Contributor

Summary

  • validate cookie names using the RFC 6265 token grammar
  • reject cookie attribute delimiters in domains and paths
  • apply the cookie-name validation when parsing Set-Cookie headers
  • add rejection and legitimate-value regression coverage

Verification

  • pnpm test run packages/platform/test/Cookies.test.ts
  • pnpm lint
  • pnpm check
  • pnpm build
  • pnpm docgen

The full pnpm test run completed with 7,539 passing tests and three unrelated failures. The MSSQL timeout and process-group timing test passed when rerun independently; the existing BigDecimal clamp assertion remains reproducible independently.

Closes EFF-211

@github-project-automation github-project-automation Bot moved this to Discussion Ongoing in PR Backlog Jul 29, 2026
@changeset-bot

changeset-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a7d1627

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/platform Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pullfrog

pullfrog Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
  • Read the complete diff and PR summary snapshot
  • Triage: understand what the PR changes, examine related files and tests
  • Specialist decision: determine if any subagent review is needed
  • Aggregate findings & draft review
  • Submit review via pullfrog_create_pull_request_review
  • Update PR summary snapshot

Pullfrog  | View workflow run | via Pullfrog | Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏

@effect-slopcop effect-slopcop Bot added 3.0 Used for issues, pull requests, etc. that are relevant for the `v3` branch targeting Effect v3. bug Something isn't working labels Jul 29, 2026
@tim-smart
tim-smart merged commit 5859b37 into v3 Jul 29, 2026
9 checks passed
@tim-smart
tim-smart deleted the agent/codex-engineer/959d616c branch July 29, 2026 23:48
@github-project-automation github-project-automation Bot moved this from Discussion Ongoing to Done in PR Backlog Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0 Used for issues, pull requests, etc. that are relevant for the `v3` branch targeting Effect v3. bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant