Propagate trace context for persisted workflow requests - #6783
Merged
Conversation
🦋 Changeset detectedLatest commit: d47bc42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Propagate trace context in
sendDiscard—Envelope.makeRequestnow receivestraceId,spanId, andsampledfrom the current span, matching the existing pattern inEntity.tsandSharding.ts. - Regression test — a new
it.effecttest instruments theWorkflowEngine.deferredDonespan, drives a deferred completion, and asserts the persisted request envelope carries matching tracing fields.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Narrowed persisted workflow envelope type — changed test assertion from
assert(envelope)toassert(envelope?._tag === "Request")so theEnvelope<any>union is properly narrowed toRequest<any>via the_tagdiscriminant, makingtraceId/spanId/sampledaccessible without type errors. - Added changeset — documented the trace context propagation fix as an
effectpatch.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
traceId,spanId, andsampledfields throughClusterWorkflowEngine.sendDiscardRoot cause
sendDiscardcreated persisted workflow request envelopes without the tracing fields already supported by the envelope and storage protocol. This broke trace parenting after the request crossed message storage and reached the workflow runner.Validation
pnpm vitest run packages/effect/test/cluster/ClusterWorkflowEngine.test.tspnpm --dir packages/effect checkpnpm exec oxlint -f unix packages/effect/src/unstable/cluster/ClusterWorkflowEngine.ts packages/effect/test/cluster/ClusterWorkflowEngine.test.tspnpm exec dprint check packages/effect/src/unstable/cluster/ClusterWorkflowEngine.ts packages/effect/test/cluster/ClusterWorkflowEngine.test.tsCloses EFF-232
Closes #6779